Crypto refactoring #382

mykola-kobets-epam · 2025-10-07T13:54:19Z

No description provided.

mlohvynenko · 2025-10-07T14:05:38Z

src/core/common/crypto/itf/crypto.hpp

+/**
+ * Random generator interface.
+ */
+class RandomItf {


shouldn't RandomItf be moved to a dedicated header (like HashItf for example)

decided to leave small interfaces inside crypto.hpp, to decrease the amount of files
but that's the open point for now

RandomItf should be placed in a separate file because it can be used standalone. You can keep aes interface with crypto, because it can be used without it.

codecov · 2025-10-07T14:06:52Z

Codecov Report

❌ Patch coverage is 94.07407% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.65%. Comparing base (b44aabc) to head (7b8815c).
⚠️ Report is 2 commits behind head on feature_unification.

Files with missing lines	Patch %	Lines
src/core/common/crypto/itf/privkey.hpp	92.85%	2 Missing ⚠️
src/core/common/crypto/itf/x509.hpp	33.33%	2 Missing ⚠️
src/core/common/crypto/cryptohelper.cpp	75.00%	1 Missing ⚠️
src/core/common/crypto/itf/rand.hpp	85.71%	1 Missing ⚠️
src/core/common/crypto/mbedtls/cryptoprovider.cpp	80.00%	1 Missing ⚠️
src/core/common/crypto/openssl/cryptoprovider.cpp	80.00%	1 Missing ⚠️

Additional details and impacted files

@@                 Coverage Diff                  @@
##           feature_unification     #382   +/-   ##
====================================================
  Coverage                81.65%   81.65%           
====================================================
  Files                      201      208    +7     
  Lines                    21959    21960    +1     
  Branches                  3053     3052    -1     
====================================================
+ Hits                     17931    17932    +1     
  Misses                    4028     4028

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mlohvynenko

Reviewed-by: Mykhailo Lohvynenko <[email protected]>

al1img · 2025-10-10T15:44:45Z

We need to add basic design document with at least purpose description of each interface. I don't think we would be able to close full crypto design document soon.

al1img · 2025-10-10T15:10:52Z

.gitignore

@@ -1,4 +1,5 @@
 build/*
 .vscode/*
+.cache/*


What is produced this folder?

it is produced by clangd server

al1img · 2025-10-10T15:18:50Z

src/core/common/crypto/itf/crypto.hpp

+/**
+ * Random generator interface.
+ */
+class RandomItf {


RandomItf should be placed in a separate file because it can be used standalone. You can keep aes interface with crypto, because it can be used without it.

al1img · 2025-10-13T07:05:57Z

src/core/common/crypto/itf/crypto.hpp

+/***
+ * UUID generator interface.
+ */
+class UUIDItf {


I guess UUID should be in separate header as well

al1img · 2025-10-13T07:07:21Z

src/core/common/crypto/itf/crypto.hpp

+/**
+ * AES cipher interface for 16-byte block encryption/decryption.
+ */
+class AESCipherItf {


And AES as well in separate aes.hpp

al1img · 2025-10-13T07:12:28Z

src/core/cm/storagestate/storagestate.hpp

 #define AOS_CORE_CM_STORAGESTATE_STORAGESTATE_HPP_

-#include <core/common/crypto/crypto.hpp>
+#include <core/common/crypto/itf/crypto.hpp>


it looks like storagestate should you only hash itf

indeed, fixed.

al1img · 2025-10-13T07:12:35Z

src/core/cm/storagestate/storagestate.md

 * [aos::fs::FSPlatformItf](../../common/tools/fs.hpp) - handle filesystem operations;
 * [aos::fs::FSWatcherItf](../../common/tools/fs.hpp) - subscribes to file change events.
-* [aos::crypto::CryptoProviderItf](../../common/crypto/crypto.hpp) - computes state file checksum;
+* [aos::crypto::CryptoProviderItf](../../common/crypto/itf/crypto.hpp) - computes state file checksum;


al1img · 2025-10-13T07:13:15Z

src/core/common/crypto/tests/cryptohelper.cpp

 }

-DecryptInfo CreateDecryptionInfo(
+cloudprotocol::DecryptInfo CreateDecryptionInfo(


cloudprotocol removed, should be rebased

outdated file

al1img · 2025-10-13T07:15:22Z

src/core/common/crypto/crypto.md

+
+The crypto module implements a dual-backend architecture, providing two complete implementations:
+
+- **MbedTLS Implementation**: Lightweight, embedded-focused cryptographic library


Lightweight -> small letter

al1img · 2025-10-13T07:15:32Z

src/core/common/crypto/crypto.md

+The crypto module implements a dual-backend architecture, providing two complete implementations:
+
+- **MbedTLS Implementation**: Lightweight, embedded-focused cryptographic library
+- **OpenSSL Implementation**: Full-featured, enterprise-grade cryptographic library


al1img · 2025-10-13T07:15:56Z

src/core/common/crypto/crypto.md

+
+## Interface Descriptions
+
+### UUIDItf


add empty line. Install md linter extension for vscode.

al1img · 2025-10-13T07:16:03Z

src/core/common/crypto/crypto.md

+### UUIDItf
+UUID generation interface for creating unique identifiers.
+
+**Methods:**


al1img

Reviewed-by: Oleksandr Grytsov <[email protected]>

MykolaSuperman

Reviewed-by: Mykola Solianko <[email protected]>

Signed-off-by: Mykola Kobets <[email protected]> Reviewed-by: Mykhailo Lohvynenko <[email protected]> Reviewed-by: Oleksandr Grytsov <[email protected]> Reviewed-by: Mykola Solianko <[email protected]>

VerifyOptions, Padding moved to crypto::x509 namespace Also removed redundant namespace qualifiers Signed-off-by: Mykola Kobets <[email protected]> Reviewed-by: Mykhailo Lohvynenko <[email protected]> Reviewed-by: Oleksandr Grytsov <[email protected]> Reviewed-by: Mykola Solianko <[email protected]>

Signed-off-by: Mykola Kobets <[email protected]> Reviewed-by: Mykhailo Lohvynenko <[email protected]> Reviewed-by: Oleksandr Grytsov <[email protected]> Reviewed-by: Mykola Solianko <[email protected]>

sonarqubecloud · 2025-10-14T09:42:29Z

Quality Gate failed

Failed conditions
1 Security Hotspot
56.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

mlohvynenko reviewed Oct 7, 2025

View reviewed changes

mlohvynenko approved these changes Oct 7, 2025

View reviewed changes

mykola-kobets-epam force-pushed the crypto-refactoring branch 4 times, most recently from 4523069 to 7e2cc45 Compare October 9, 2025 10:50

al1img reviewed Oct 10, 2025

View reviewed changes

mykola-kobets-epam force-pushed the crypto-refactoring branch 2 times, most recently from d07756d to f523031 Compare October 11, 2025 22:33

al1img reviewed Oct 13, 2025

View reviewed changes

mykola-kobets-epam force-pushed the crypto-refactoring branch from f523031 to e421564 Compare October 13, 2025 08:48

al1img approved these changes Oct 14, 2025

View reviewed changes

MykolaSuperman approved these changes Oct 14, 2025

View reviewed changes

mlohvynenko approved these changes Oct 14, 2025

View reviewed changes

mykola-kobets-epam added 8 commits October 14, 2025 12:26

gitignore: add .cache to .gitignore

a1c9992

Signed-off-by: Mykola Kobets <[email protected]> Reviewed-by: Mykhailo Lohvynenko <[email protected]> Reviewed-by: Oleksandr Grytsov <[email protected]> Reviewed-by: Mykola Solianko <[email protected]>

crypto: split crypto.hpp on dedicated header files

d4d06b7

Signed-off-by: Mykola Kobets <[email protected]> Reviewed-by: Mykhailo Lohvynenko <[email protected]> Reviewed-by: Oleksandr Grytsov <[email protected]> Reviewed-by: Mykola Solianko <[email protected]>

crypto: rename crypto.cpp to asn1.cpp

0cf6565

Signed-off-by: Mykola Kobets <[email protected]> Reviewed-by: Mykhailo Lohvynenko <[email protected]> Reviewed-by: Oleksandr Grytsov <[email protected]> Reviewed-by: Mykola Solianko <[email protected]>

crypto: rename cryptoutils to certloader

87586f5

Signed-off-by: Mykola Kobets <[email protected]> Reviewed-by: Mykhailo Lohvynenko <[email protected]> Reviewed-by: Oleksandr Grytsov <[email protected]> Reviewed-by: Mykola Solianko <[email protected]>

all: fix crypto includes

4314cb1

Signed-off-by: Mykola Kobets <[email protected]> Reviewed-by: Mykhailo Lohvynenko <[email protected]> Reviewed-by: Oleksandr Grytsov <[email protected]> Reviewed-by: Mykola Solianko <[email protected]>

common: add WITH_TEST_TOOLS to provide test tools with disabled tests

35d8dc6

Signed-off-by: Mykola Kobets <[email protected]> Reviewed-by: Mykhailo Lohvynenko <[email protected]> Reviewed-by: Oleksandr Grytsov <[email protected]> Reviewed-by: Mykola Solianko <[email protected]>

crypto: add crypto documentation

7b8815c

Signed-off-by: Mykola Kobets <[email protected]> Reviewed-by: Mykhailo Lohvynenko <[email protected]> Reviewed-by: Oleksandr Grytsov <[email protected]> Reviewed-by: Mykola Solianko <[email protected]>

mykola-kobets-epam force-pushed the crypto-refactoring branch from e421564 to 7b8815c Compare October 14, 2025 09:28


		The crypto module implements a dual-backend architecture, providing two complete implementations:

		- MbedTLS Implementation: Lightweight, embedded-focused cryptographic library

Crypto refactoring #382

Are you sure you want to change the base?

Crypto refactoring #382

Conversation

mykola-kobets-epam commented Oct 7, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mlohvynenko left a comment

Choose a reason for hiding this comment

Uh oh!

al1img commented Oct 10, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

al1img left a comment

Choose a reason for hiding this comment

Uh oh!

MykolaSuperman left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Oct 14, 2025

Quality Gate failed

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

codecov bot commented Oct 7, 2025 •

edited

Loading