-
Notifications
You must be signed in to change notification settings - Fork 6
common: iamclient: add current node info provider interface #385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature_unification
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed-by: Mykhailo Lohvynenko <[email protected]>
#include <core/common/types/common.hpp> | ||
|
||
namespace aos::iamclient { | ||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an empty line
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature_unification #385 +/- ##
====================================================
Coverage 81.65% 81.65%
====================================================
Files 201 201
Lines 21959 21959
Branches 3053 3053
====================================================
Hits 17931 17931
Misses 4028 4028 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
201d27e
to
d817286
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed-by: Mykola Kobets <[email protected]>
Signed-off-by: Oleksandr Grytsov <[email protected]> Reviewed-by: Mykhailo Lohvynenko <[email protected]> Reviewed-by: Mykola Kobets <[email protected]>
Most of headers doesn't have this comment and it is hard to update when name or path of header changed. Remove it to align with other headers. Signed-off-by: Oleksandr Grytsov <[email protected]> Reviewed-by: Mykhailo Lohvynenko <[email protected]> Reviewed-by: Mykola Kobets <[email protected]>
d817286
to
b1cad61
Compare
|
No description provided.