Skip to content

Conversation

@al1img
Copy link
Collaborator

@al1img al1img commented Oct 13, 2025

No description provided.

@codecov
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

❌ Patch coverage is 81.72043% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.61%. Comparing base (ffb257b) to head (4762698).
⚠️ Report is 13 commits behind head on feature_unification.

Files with missing lines Patch % Lines
...ler/identmodules/fileidentifier/fileidentifier.hpp 0.00% 8 Missing ⚠️
src/core/iam/tests/mocks/certhandlermock.hpp 0.00% 3 Missing ⚠️
...rc/core/common/crypto/tests/stubs/certprovider.hpp 33.33% 2 Missing ⚠️
src/core/common/tests/mocks/permhandlermock.hpp 0.00% 2 Missing ⚠️
src/core/cm/imagemanager/imagemanager.cpp 50.00% 1 Missing ⚠️
...ler/identmodules/fileidentifier/fileidentifier.cpp 75.00% 1 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##           feature_unification     #386      +/-   ##
=======================================================
- Coverage                81.65%   81.61%   -0.05%     
=======================================================
  Files                      208      209       +1     
  Lines                    21960    21928      -32     
  Branches                  3052     3055       +3     
=======================================================
- Hits                     17932    17897      -35     
- Misses                    4028     4031       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@al1img al1img force-pushed the update_interfaces branch from 075a59b to d4c75aa Compare October 13, 2025 19:20
@al1img al1img changed the title Update common iamclient Update common iamclient interface Oct 13, 2025
Copy link

@MykolaSuperman MykolaSuperman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Mykola Solianko <[email protected]>

Copy link
Contributor

@mykola-kobets-epam mykola-kobets-epam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Mykola Kobets <[email protected]>

Copy link
Member

@mlohvynenko mlohvynenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Mykhailo Lohvynenko <[email protected]>

@al1img al1img force-pushed the update_interfaces branch 2 times, most recently from 7bd37ae to 3c50e6c Compare October 14, 2025 11:04
@al1img al1img force-pushed the update_interfaces branch 2 times, most recently from 668eff2 to 7130b14 Compare October 14, 2025 14:38
@al1img al1img force-pushed the update_interfaces branch from 7130b14 to a926299 Compare October 14, 2025 19:27
Cert handler implements same methods as cert provider and it can be used
instead.

Signed-off-by: Oleksandr Grytsov <[email protected]>
@al1img al1img force-pushed the update_interfaces branch from a926299 to 4762698 Compare October 15, 2025 08:04
@sonarqubecloud
Copy link

@al1img al1img merged commit 00c68e8 into aosedge:feature_unification Oct 15, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants