Skip to content

Conversation

@vincbeck
Copy link
Contributor

See what breaks.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@vincbeck vincbeck added the full tests needed We need to run full set of tests for this PR to merge label Sep 29, 2025
@vincbeck vincbeck closed this Sep 29, 2025
@vincbeck vincbeck reopened this Sep 29, 2025
@vincbeck vincbeck force-pushed the vincbeck/fab_remove_sqla_limit branch 9 times, most recently from c1fa45c to 402c06d Compare October 1, 2025 14:09
@vincbeck vincbeck force-pushed the vincbeck/fab_remove_sqla_limit branch 3 times, most recently from 7212d8c to ddaa295 Compare October 1, 2025 15:58
@vincbeck vincbeck force-pushed the vincbeck/fab_remove_sqla_limit branch 8 times, most recently from 3606361 to 25f1bda Compare October 2, 2025 13:28
@vincbeck vincbeck force-pushed the vincbeck/fab_remove_sqla_limit branch from 25f1bda to 6713327 Compare October 15, 2025 22:01
@potiuk
Copy link
Member

potiuk commented Oct 16, 2025

Getting closer?

@vincbeck
Copy link
Contributor Author

Getting closer?

  Found 525 errors in 100 files (checked 996 source files)

Kinda :) I'll create an issue to get help from the community to resolve all these static errors

@vincbeck vincbeck force-pushed the vincbeck/fab_remove_sqla_limit branch 3 times, most recently from ca14a57 to 8d579cf Compare November 3, 2025 20:21
@vincbeck vincbeck force-pushed the vincbeck/fab_remove_sqla_limit branch 6 times, most recently from cd9bcb3 to 6df9b3d Compare November 4, 2025 18:54
@vincbeck vincbeck force-pushed the vincbeck/fab_remove_sqla_limit branch from 6df9b3d to 2e2fcb3 Compare November 4, 2025 19:55
@vincbeck
Copy link
Contributor Author

vincbeck commented Nov 4, 2025

@potiuk should we set sqlalchemy>=2? Min SQLAlchemy tests are failing because there is a conflict with redshift-sqlalchemy, which is surprising because we do not have this issue today.

@potiuk
Copy link
Member

potiuk commented Nov 4, 2025

@potiuk should we set sqlalchemy>=2? Min SQLAlchemy tests are failing because there is a conflict with redshift-sqlalchemy, which is surprising because we do not have this issue today.

Yes. I think that would be a good idea. There is nothing holding us with SQLalchemy 1 for Airflow 3.2

@vincbeck vincbeck force-pushed the vincbeck/fab_remove_sqla_limit branch 5 times, most recently from c098e49 to 7f205b9 Compare November 5, 2025 20:42
@vincbeck
Copy link
Contributor Author

vincbeck commented Nov 5, 2025

All tests are passing but mypy-airflow-core and mypy-task-sdk 🥳

@vincbeck vincbeck force-pushed the vincbeck/fab_remove_sqla_limit branch from 7f205b9 to 4e85331 Compare November 5, 2025 20:44
@vincbeck vincbeck force-pushed the vincbeck/fab_remove_sqla_limit branch 2 times, most recently from bd5caff to 4c649eb Compare November 6, 2025 15:55
@vincbeck vincbeck force-pushed the vincbeck/fab_remove_sqla_limit branch from 4c649eb to 3b5be06 Compare November 7, 2025 13:00
@vincbeck
Copy link
Contributor Author

vincbeck commented Nov 7, 2025

Closing in favor of #58049

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

all versions If set, the CI build will be forced to use all versions of Python/K8S/DBs full tests needed We need to run full set of tests for this PR to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants