fix(asset-alias): Preserve Asset.extra when using AssetAlias
#58038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Lee-W
force-pushed
the
fix-asset-alias-asset-extra
branch
2 times, most recently
from
77c88c4 to
51160d0
Compare
Lee-W
requested review from
XD-DENG,
amoghrajesh,
ashb,
bolkedebruin and
kaxil
as code owners
Lee-W
changed the title
Asset.extra when using AssetAlias
Lee-W
added
the
backport-to-v3-1-test
Lee-W
force-pushed
the
fix-asset-alias-asset-extra
branch
4 times, most recently
from
e7f2ac0 to
219f1e4
Compare
uranusjr
reviewed
Nov 19, 2025
uranusjr
reviewed
Nov 19, 2025
Lee-W
force-pushed
the
fix-asset-alias-asset-extra
branch
from
219f1e4 to
6824b86
Compare
uranusjr
approved these changes
Nov 26, 2025
Member
uranusjr
left a comment
uranusjr
left a comment
There was a problem hiding this comment.
Let’s create an issue to track the documentation change mentioned above.
Member
Author
|
Yep, added the issue |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 26, 2025
…tAlias` (#58038) (cherry picked from commit 8d121e1) Co-authored-by: Wei Lee <[email protected]>
Backport successfully created: v3-1-test
|
Lee-W
added a commit
to astronomer/airflow
that referenced
this pull request
Nov 26, 2025
…tAlias` (apache#58038) (cherry picked from commit 8d121e1) Co-authored-by: Wei Lee <[email protected]>
Lee-W
added a commit
to astronomer/airflow
that referenced
this pull request
Nov 26, 2025
…tAlias` (apache#58038) (cherry picked from commit 8d121e1) Co-authored-by: Wei Lee <[email protected]>
github-actions bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Nov 26, 2025
…tAlias` (apache#58038) (cherry picked from commit 8d121e1) Co-authored-by: Wei Lee <[email protected]>
Lee-W
added a commit
that referenced
this pull request
Nov 26, 2025
…tAlias` (#58038) (#58712) Co-authored-by: Wei Lee <[email protected]>
ephraimbuddy
pushed a commit
that referenced
this pull request
Dec 3, 2025
…tAlias` (#58038) (#58712) Co-authored-by: Wei Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
I misundertood
Asset.extraandAssetEvent.extraback to the time we implement thisAssetAliasfeatureCloses: #58146
What
Asset.extrainformation when AssetAlias is used. This also works whenAssetRef(name=...)orAssetRef(uri=...)is used to reference an existing Asset with extra set.AssetAliasEventto takedest_asset_extra_resolve_asset_refto returntuple[AssetUniqueKey, dict[str, JsonValue]]related: #55200
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.