Skip to content

[Improvement]: Refactor process API and table runtime extension interfaces #4097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
majin1102 merged 7 commits into from
Feb 25, 2026
Merged

[Improvement]: Refactor process API and table runtime extension interfaces #4097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
731ccb7
improvement: refactor process API and table runtime extension interfaces
Feb 18, 2026
f1f8ecf
Merge branch 'master' into process-factory/new-process-api
baiyangtx Feb 20, 2026
50f1e7e
fix compile error
Feb 20, 2026
26812d8
fix compile error
Feb 20, 2026
638c0bf
fix compile error3
Feb 20, 2026
9490191
getTableConfig
Feb 25, 2026
d665c55
refactor
Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 0 additions & 87 deletions amoro-ams/src/main/java/org/apache/amoro/server/persistence/mapper/ProcessStateMapper.java
View file
Open in desktop

This file was deleted.

17 changes: 5 additions & 12 deletions amoro-ams/src/main/java/org/apache/amoro/server/process/ActionCoordinatorScheduler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,16 @@

import org.apache.amoro.TableFormat;
import org.apache.amoro.TableRuntime;
import org.apache.amoro.process.ActionCoordinator;
import org.apache.amoro.process.TableProcess;
import org.apache.amoro.process.TableProcessStore;
import org.apache.amoro.server.scheduler.PeriodicTableScheduler;
import org.apache.amoro.server.table.TableService;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import java.util.Optional;

/**
* Periodic scheduler that delegates scheduling decisions to an {@link ActionCoordinator}. It
* creates, recovers and retries table processes via {@link ProcessService}.
Expand Down Expand Up @@ -95,8 +98,8 @@ protected boolean enabled(TableRuntime tableRuntime) {
*/
@Override
protected void execute(TableRuntime tableRuntime) {
TableProcess process = coordinator.createTableProcess(tableRuntime);
processService.register(tableRuntime, process);
Optional<TableProcess> process = coordinator.trigger(tableRuntime);
process.ifPresent(p -> processService.register(tableRuntime, p));
}

/**
Expand All @@ -110,16 +113,6 @@ protected void recover(TableRuntime tableRuntime, TableProcessStore processStore
processService.recover(tableRuntime, process);
}

/**
* Retry a failed table process.
*
* @param process process to retry
*/
protected void retry(TableProcess process) {
process = coordinator.retryTableProcess(process);
processService.retry(process);
}

/**
* Get executor delay from coordinator.
*
Expand Down
3 changes: 2 additions & 1 deletion amoro-ams/src/main/java/org/apache/amoro/server/process/ProcessService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import org.apache.amoro.TableRuntime;
import org.apache.amoro.config.Configurations;
import org.apache.amoro.config.TableConfiguration;
import org.apache.amoro.process.ActionCoordinator;
import org.apache.amoro.process.ProcessEvent;
import org.apache.amoro.process.ProcessStatus;
import org.apache.amoro.process.TableProcess;
Expand Down Expand Up @@ -242,7 +243,7 @@ private void executeOrTraceProcess(TableProcess process) {
"Regular Retry.",
process.getProcessParameters(),
process.getSummary());
scheduler.retry(process);
executeOrTraceProcess(process);
} else {
untrackTableProcessInstance(
process.getTableRuntime().getTableIdentifier(), process.getId());
Expand Down
20 changes: 0 additions & 20 deletions amoro-ams/src/main/java/org/apache/amoro/server/process/TableProcessMeta.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
package org.apache.amoro.server.process;

import org.apache.amoro.process.ProcessStatus;
import org.apache.amoro.process.TableProcessState;
import org.apache.amoro.process.TableProcessStore;

import java.util.HashMap;
Expand Down Expand Up @@ -189,25 +188,6 @@ public static TableProcessMeta fromTableProcessStore(TableProcessStore tableProc
return tableProcessMeta;
}

@Deprecated
public static TableProcessMeta fromTableProcessState(TableProcessState tableProcessState) {
TableProcessMeta tableProcessMeta = new TableProcessMeta();
tableProcessMeta.setProcessId(tableProcessState.getId());
tableProcessMeta.setTableId(tableProcessState.getTableIdentifier().getId());
tableProcessMeta.setExternalProcessIdentifier(tableProcessState.getExternalProcessIdentifier());
tableProcessMeta.setStatus(tableProcessState.getStatus());
tableProcessMeta.setProcessType(tableProcessState.getAction().getName());
tableProcessMeta.setProcessStage(tableProcessState.getStage().getDesc());
tableProcessMeta.setExecutionEngine(tableProcessState.getExecutionEngine());
tableProcessMeta.setRetryNumber(tableProcessState.getRetryNumber());
tableProcessMeta.setCreateTime(tableProcessState.getStartTime());
tableProcessMeta.setFinishTime(tableProcessState.getEndTime());
tableProcessMeta.setFailMessage(tableProcessState.getFailedReason());
tableProcessMeta.setProcessParameters(tableProcessState.getProcessParameters());
tableProcessMeta.setSummary(tableProcessState.getSummary());
return tableProcessMeta;
}

public static TableProcessMeta of(
long processId,
long tableId,
Expand Down
Loading