Bump rust edition to 2024, rust version to 1.85

[AdamGS]

Which issue does this PR close?

Unlocks #514.

Rationale for this change

90% of downloads use 1.85, and 2024 unlocks future msrv bumps.

What changes are included in this PR?

Bumping rust edition and msrv.

Are there any user-facing changes?

Increasing the msrv might have an impact on some dependencies and users, but I assume the vast majority of them will be fine with upgrading (For example - DataFusion is at 1.86 and arrow-rs is at 1.85).

[Xuanwo]

Arrow-rs is bumped to edition 2024, and 1.85 is now used by 90% of downloads based on stats from https://lib.rs/stats. I believe it's fair to bump to 2024 now. Another advantage of edition 2024 is that raising the MSRV is no longer a breaking change, making this a one shot solution.

[AdamGS]

good points, I'll have that later today/tomorrow

[AdamGS]

Ok pushed it, bumped msrv to 1.85 and the rust edition to 2024.

[AdamGS]

most of the change is just the new rutfmt ordering, other than that its just a few clippy warnings

[alamb]

Since this increases the MSRV woudl that make it a breaking change (aka we can only release this as part of a major release)?

[alamb]

Thanks @AdamGS and @Xuanwo

[kylebarron]

IIRC MSRV updates are considered to be "non-breaking", though I can't recall a canonical source for that.

[alamb]

IIRC MSRV updates are considered to be "non-breaking", though I can't recall a canonical source for that.

Here is one source:

• Minimum Supported Rust Version (MSRV) Policies rust-lang/api-guidelines#231

Though it has a lot of discussion which I didn't read

[Xuanwo]

Yes, it's considered a non-breaking change. But only after edition 2024 it becomes a really non-harmful thing thanks to https://doc.rust-lang.org/edition-guide/rust-2024/cargo-resolver.html

So my suggestion is that we still treat this change as a breaking one and after this PR, we can bump MSRV freely.

[alamb]

So shall we merge this one in and plan to cut a new major release of object_store?

[AdamGS]

Should I also remove the --precise pining in the msrv check in CI?

[kylebarron]

It would be great if we could remove that section

[alamb]

Sounds great -- I will plan on making a new release in Nov

• Release object store 0.13.0 (breaking) - Target Nov 2025 #367
  Let's get this code moving