feat: Add support for AWS_ENDPOINT_URL_S3 environment variable#590
feat: Add support for AWS_ENDPOINT_URL_S3 environment variable#590rajatgoel wants to merge 3 commits intoapache:mainfrom
Conversation
|
Unless this is something standard, i.e. supported by AWS SDKs, I'm a bit lukewarm on this. I don't want to be in a position where we have to support a huge number of config names just because they happen to collide in some people's environments.
|
|
Yes, this is a standard aws env var - https://docs.aws.amazon.com/sdkref/latest/guide/feature-ss-endpoints.html |
src/aws/builder.rs
Outdated
| builder = builder.with_config(config_key, value); | ||
| } | ||
| } | ||
| // Collect and sort environment variables to ensure deterministic precedence. |
There was a problem hiding this comment.
Can we instead add a separate config key for this + member variable, and then implement this priority in the build method. Otherwise this behaviour becomes specific to from_env and will break for methods that use with_config directly - e.g. parse_url
There was a problem hiding this comment.
Done. Now we handle it the same way we do AWS_ENDPOINT_URL_STS.
2 participants
Which issue does this PR close?
Closes #589
What changes are included in this PR?
There are 2 changes -
AWS_ENDPOINT_URL_S3as an alternative env var that sets S3 endpoint.Are there any user-facing changes?
If this env var is not set, this should be a no-op. But if this env var is set,
our code will start respecting that. Probably worth calling out in the release notes.