[AURON #2050] Support UnaryMinus expression#2051
Open
yew1eb wants to merge 2 commits intoapache:masterfrom
Open
[AURON #2050] Support UnaryMinus expression#2051yew1eb wants to merge 2 commits intoapache:masterfrom
yew1eb wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds native support for Spark Catalyst UnaryMinus expressions so queries using negative(col) or -(col) no longer fall back to Spark execution.
Changes:
- Extend
NativeConvertersto translateUnaryMinusinto the protobufPhysicalNegativeNode. - Add a Spark SQL integration test covering
negative(col1)and-(col1)over a Parquet table (including nulls and edge int values).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| spark-extension/src/main/scala/org/apache/spark/sql/auron/NativeConverters.scala | Adds conversion logic for Catalyst UnaryMinus to PhysicalNegativeNode in the native expression protobuf. |
| spark-extension-shims-spark/src/test/scala/org/apache/auron/AuronExpressionSuite.scala | Adds a test ensuring unary minus executes with the native operator and matches Spark results. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yew1eb
force-pushed
the
AURON_2050
branch
5 times, most recently
from
746266f to
276ed37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2050
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?
How was this patch tested?