[AURON #2052] [BUG] NPE risk in AuronUniffleShuffleReader.#2053
Merged
zuston merged 1 commit intoapache:masterfrom Mar 4, 2026
Merged
[AURON #2052] [BUG] NPE risk in AuronUniffleShuffleReader.#2053zuston merged 1 commit intoapache:masterfrom
zuston merged 1 commit intoapache:masterfrom
Conversation
Signed-off-by: slfan1989 <slfan1989@apache.org>
Contributor
Author
Contributor
Author
@zuston Thank you very much for helping to review the code! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2052
Rationale for this change
In
AuronUniffleShuffleReader, there are potentialNullPointerExceptionrisks when handling partitions:partitionToExpectBlocks.get(partition)may return null, but the code directly calls.isEmpty()without null checkpartitionToShuffleServers.get(partition)may return null, but the code uses it directly without validationThis can cause the shuffle reader to crash when reading partitions that have missing or incomplete metadata.This can cause the shuffle reader to crash when reading partitions that have missing or incomplete metadata.
What changes are included in this PR?
Are there any user-facing changes?
No.
How was this patch tested?
Exists Junit Test.