fix: Union serialization #366
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for the issue described here: #365
Changes
SeqVariantSerializerandStructVariantSerializerto serialize Enum variants asUnion(...)directlyinstead of
Record([("type", Enum(...)) ("value, Union(...))]);variantanymore, I removed the field and removed the lifetime annotationthat was only needed because this field was a
&str;SeqVariantSerializerhad two implementations:ser::SerializeTupleVariantandser::SerializeStructVariant,where the first one delegated everything to the second one, but the second one was never used by itself,
so I removed it;
resolve_unionfunction so that it uses the index fromValue::Unionto get the correct schema;
UnionIndexOutOfBoundsfor cases where this index gets out of bounds;