feat: Use the Serde attributes and check for conflicting attributes #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kriskras99
changed the title
Kriskras99
force-pushed
the
feat/use_serde_attributes
branch
from
fad2499 to
9c7a490
Compare
Kriskras99
changed the title
19 tasks
Kriskras99
force-pushed
the
feat/use_serde_attributes
branch
from
9c7a490 to
2f02fa0
Compare
This commit changes the attribute parsing in `#[derive(AvroSchema)]` to also use the Serde attributes. It will use the Serde attributes and check that they match the Avro attributes if provided. It will also check that known incompatible Serde attributes result in a compile error instead of a runtime panic. Testing for the compile errors is done using `trybuild`. These tests run only on nightly as the output can vary between compiler versions (otherwise MSRV and latest stable could have different outputs and break the entire CI).
Kriskras99
force-pushed
the
feat/use_serde_attributes
branch
from
2f02fa0 to
0ed7a90
Compare
Kriskras99
changed the base branch from
main
to
chore/remove_unnecessary_mod
Contributor
Author
|
I've moved the indentation change to a separate PR (#375) to make this easier to review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the attribute parsing in
#[derive(AvroSchema)]to also use the Serde attributes.It will use the Serde attributes and check that they match the Avro attributes if provided. It will
also check that known incompatible Serde attributes result in a compile error instead of a runtime panic.
Testing for the compile errors is done using
trybuild. These tests run only on nightly as the output can vary between compiler versions (otherwise MSRV and latest stable could have different outputs and break the entire CI).The large amount of changes in
avro_derive/tests/derive.rsis because I removed the unnecessary test module, which changed the indentation of every line.