Skip to content

Align mqtt5 disconnect packet behavior. #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2024
Merged

Align mqtt5 disconnect packet behavior. #107

merged 1 commit into from
Dec 11, 2024

Conversation

Gujiawei-Edinburgh
Copy link
Contributor

  1. The reason code and property length can be omitted iif the reason code is normal and there are no properties

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12256473697

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 20 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.02%) to 65.564%
Files with Coverage Reduction New Missed Lines %
com/baidu/bifromq/dist/trie/TopicFilterIterator.java 1 71.37%
com/baidu/bifromq/basecrdt/core/internal/CausalCRDTInflater.java 1 92.67%
com/baidu/bifromq/basecluster/memberlist/agent/Agent.java 1 94.26%
com/baidu/bifromq/basekv/raft/RaftNodeStateLeader.java 1 87.19%
com/baidu/bifromq/basecluster/memberlist/HostMemberList.java 1 92.1%
com/baidu/bifromq/mqtt/handler/v5/MQTT5MessageBuilders.java 3 70.71%
com/baidu/bifromq/basecluster/transport/TCPTransport.java 4 86.93%
com/baidu/bifromq/basekv/raft/RaftNodeStateFollower.java 8 84.19%
Totals Coverage Status
Change from base Build 11587481326: 0.02%
Covered Lines: 21800
Relevant Lines: 32247
💛 - Coveralls

popduke
popduke approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@popduke popduke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@popduke popduke merged commit 362d656 into apache:main Dec 11, 2024
1 check passed
@Gujiawei-Edinburgh Gujiawei-Edinburgh deleted the bf-align-behavior branch December 11, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@popduke popduke popduke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gujiawei-Edinburgh @coveralls @popduke