[CAMEL-22557] AS2: Fix configuration isolation and enable port sharing for inbound routes

[brunovg]

Description

This Pull Request addresses a major architectural limitation in the camel-as2 component where multiple inbound AS2 Consumers (routes) could not share the same port number.

The previous architecture led to two primary issues:

Port Binding Failure: The second route attempting to start would fail with an "Address already in use" error.

Configuration Collision: Even if the port binding was bypassed, encrypted messages failed with a NullPointerException or AS2DecryptionException because the shared server connection's cryptographic keys were overwritten or set to null and could not be retrieved by the correct Consumer.

CAMEL-22557: camel-as2 - Server-side DecryptingPrivateKey Conflict: Key from first route started is enforced for all subsequent routes on the same serverPortNumber

[Croway]

Thanks for the contribution @brunovg , could you add a test that shows this improvement?

[github-actions]

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

• First-time contributors require MANUAL approval for the GitHub Actions to run

• You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

• You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

• Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

• ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

[claudio4j]

Thanks for the contribution!
Specifically the tests for the new parameter requestUriPattern are important and thise use case to have different decryptingPrivateKey for the servers listening on the same port.
I ran mvn -ntp verify -f components/camel-as2/ and there are many failures, try mvn install -Psourcecheck -DskipTests -f components/camel-as2/ also.
These changes should go first to main branch, then after merge to backport to the 4.10 and 4.14 branches.
I'm going to review the design changes.

[orpiske]

Thanks, it looks like a great feature improvement! There's a few things that need to be adjusted, though (including tests, as reported).

[claudio4j]

The CI reports failures for the camel-catalog and endpointdsl, you can regenerate the as2 files with mvn install -DskipTests -pl :camel-endpointdsl,:camel-catalog

[davsclaus]

Can you update the PR with these files

	modified:   components/camel-as2/camel-as2-component/src/test/java/org/apache/camel/component/as2/AS2ServerTwoConsumerBase.java
	modified:   components/camel-as2/camel-as2-component/src/test/java/org/apache/camel/component/as2/AS2ServerTwoConsumerSecEncryptedIT.java

The build is reformatting the code. And because of that the CI build fails

[davsclaus]

Are you able to update those 2 source files, so we can continue this PR and this will also allow CI to test the code

[brunovg]

Are you able to update those 2 source files, so we can continue this PR and this will also allow CI to test the code

The new unit test class that I uploaded is not working yet.
I uploaded so that @claudio4j could take a look on it.

For some reason, the fix I submitted, doesn't work on the unit tests.
I'm still working on an alternative fix.

[claudio4j]

It's good to squash the commits and rebase to 4.10.x branch.
Also open a PR to the main and 4.14.x branch.

[davsclaus]

It's good to squash the commits and rebase to 4.10.x branch. Also open a PR to the main and 4.14.x branch.

Frankly it would be best with a new PR against main branch only. Then its easier for everyone else to help test and review. And then afterwards we can then cherry-pick to LTS branches. And if something need manual code changes then ask for PRs against a specific branches.

This ensures that the code is always applied to main first and then go down when applicable.

[davsclaus]

Would be awesome if you are able to send a PR for main branch today as then its a chance to get into 4.16.0, which makes it easier for you and everyone else to test and use and report issues that allows us to fix this in upcoming releases, and help ensure that backports to LTS branches are worth "any risk".

[brunovg]

PR on main branch: #19768