[CELEBORN-2291] Support fsync on commit to ensure shuffle data durability#3635
Open
kaybhutani wants to merge 2 commits intoapache:mainfrom
Open
[CELEBORN-2291] Support fsync on commit to ensure shuffle data durability#3635kaybhutani wants to merge 2 commits intoapache:mainfrom
kaybhutani wants to merge 2 commits intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add a new configuration
celeborn.worker.commitFiles.fsync(defaultfalse) that callsFileChannel.force(false)(fdatasync) before closing the channel inLocalTierWriter.closeStreams().Why are the changes needed?
Without this, committed shuffle data can sit in the OS page cache before the kernel flushes it to disk. A hard crash in that window loses data even though Celeborn considers it committed. This option lets operators opt into stronger durability guarantees.
Does this PR resolve a correctness bug?
No. It adds an optional durability enhancement.
Does this PR introduce any user-facing change?
Yes. New configuration key
celeborn.worker.commitFiles.fsync(boolean, defaultfalse).How was this patch tested?
Existing unit tests. Configuration verified via
ConfigurationSuiteand for LocalTierWriter added a new test with fsync enabled and ranTierWriterSuite.Additional context: slack