Fix Oid display errors in the log or message#1583
Open
fairyfar wants to merge 1 commit intoapache:mainfrom
Open
Fix Oid display errors in the log or message#1583fairyfar wants to merge 1 commit intoapache:mainfrom
fairyfar wants to merge 1 commit intoapache:mainfrom
Conversation
reshke
approved these changes
Feb 28, 2026
leborchuk
approved these changes
Mar 1, 2026
Oid is unsigned int. Therefore, when the Oid reaches 2^31, printing it with %d will display a negative value. This is a defect of the original GPDB. GPDB has fixed similar defects on commit 7279a1e('Fix getResUsage integer overflow'), but there are still omissions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Oid display errors in the log or message
What does this PR do?
Oid is unsigned int. Therefore, when the Oid reaches 2^31, printing it with %d will display a negative value.
Although it does not affect the feature,but in certain circumstances, deformedlog messages may occur.
This is a defect of the original GPDB. GPDB has fixed similar defects on commit 7279a1e('Fix getResUsage integer overflow'), but there are still omissions.
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions