pre-commit upgrade codespell; fix spelling; configure gitleaks #10144

jbampton · 2024-12-28T09:09:32Z

Description

This PR...

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov · 2024-12-28T09:17:04Z

Codecov Report

❌ Patch coverage is 25.00000% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.39%. Comparing base (0108ffd) to head (92bccb3).
⚠️ Report is 83 commits behind head on main.

Files with missing lines	Patch %	Lines
...cloud/storage/resource/VmwareStorageProcessor.java	0.00%	9 Missing ⚠️
...ava/com/cloud/upgrade/dao/Upgrade41810to41900.java	0.00%	1 Missing ⚠️
...oud/hypervisor/vmware/resource/VmwareResource.java	0.00%	1 Missing ⚠️
.../java/com/cloud/hypervisor/HypervisorGuruBase.java	0.00%	1 Missing ⚠️
...a/com/cloud/storage/StoragePoolAutomationImpl.java	0.00%	1 Missing ⚠️
...oud/consoleproxy/ConsoleProxyThumbnailHandler.java	0.00%	1 Missing ⚠️
...va/com/cloud/hypervisor/vmware/mo/DatastoreMO.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #10144      +/-   ##
============================================
- Coverage     17.39%   17.39%   -0.01%     
+ Complexity    15283    15281       -2     
============================================
  Files          5889     5889              
  Lines        526183   526183              
  Branches      64242    64242              
============================================
- Hits          91541    91538       -3     
- Misses       424298   424300       +2     
- Partials      10344    10345       +1

Flag	Coverage Δ
uitests	`3.62% <ø> (ø)`
unittests	`18.44% <25.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

DaanHoogland

I think we could refuse a lot of those spellos but lgtm like this as well (non native ;)

jbampton · 2024-12-28T11:39:36Z

@blueorangutan package

blueorangutan · 2024-12-28T11:40:07Z

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-12-28T11:55:10Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 11930

DaanHoogland · 2024-12-29T20:33:28Z

@blueorangutan package

blueorangutan · 2024-12-29T20:34:03Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-12-29T21:49:15Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11939

.github/linters/codespell.txt

github-actions · 2025-01-08T14:37:52Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

github-actions · 2025-09-17T12:10:37Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

DaanHoogland · 2025-09-17T12:30:36Z

@blueorangutan package

blueorangutan · 2025-09-17T12:32:04Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-09-17T14:11:14Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15061

DaanHoogland · 2025-09-17T15:43:46Z

@blueorangutan test

blueorangutan · 2025-09-17T15:46:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

vishesh92 · 2025-09-17T16:37:40Z

@jbampton I merged another PR (#11284) which resulted in the conflicts. Please check & resolve the conflicts.

github-actions · 2025-09-17T18:37:58Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

jbampton · 2025-09-17T23:51:20Z

@blueorangutan package

blueorangutan · 2025-09-17T23:52:03Z

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-09-18T01:09:12Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15067

blueorangutan · 2025-09-18T03:58:22Z

[SF] Trillian test result (tid-14366)
Environment: kvm-ubuntu22 (x2), zone: Advanced Networking with Mgmt server u22
Total time taken: 60202 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10144-t14366-kvm-ubuntu22.zip
Smoke tests completed. 146 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	1.17	test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster	`Failure`	28.97	test_kubernetes_clusters.py

blueorangutan · 2025-09-18T05:17:47Z

[SF] Trillian test result (tid-14365)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 64186 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10144-t14365-kvm-ol8.zip
Smoke tests completed. 144 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	1.15	test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster	`Failure`	26.80	test_kubernetes_clusters.py
test_02_create_template_with_checksum_sha1	`Error`	65.65	test_templates.py
test_04_deploy_vnf_appliance	`Error`	311.84	test_vnf_templates.py
test_05_delete_vnf_template	`Error`	1.10	test_vnf_templates.py
ContextSuite context=TestVnfTemplates>:teardown	`Error`	2.22	test_vnf_templates.py

DaanHoogland · 2025-09-18T06:42:35Z

@blueorangutan test

blueorangutan · 2025-09-18T06:44:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-09-18T08:11:01Z

[SF] Trillian test result (tid-14367)
Environment: vmware-70u3 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 75061 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10144-t14367-vmware-70u3.zip
Smoke tests completed. 126 look OK, 5 have errors, 16 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	1.20	test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster	`Failure`	42.63	test_kubernetes_clusters.py
test_01_ssl_offloading_isolated_network	`Failure`	786.03	test_ssl_offloading.py
test_02_ssl_offloading_project_vpc	`Failure`	790.73	test_ssl_offloading.py
test_01_vpn_usage	`Error`	1.11	test_usage.py
test_01_deploy_vm_on_specific_host	`Error`	18.74	test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster	`Error`	3602.12	test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod	`Error`	4.77	test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster	`Error`	4.42	test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod	`Error`	2.43	test_vm_deployment_planner.py
ContextSuite context=TestDeployVM>:setup	`Error`	0.00	test_vm_life_cycle.py
ContextSuite context=TestKVMLiveMigration>:setup	`Error`	0.00	test_vm_life_cycle.py
ContextSuite context=TestMigrateVMwithVolume>:setup	`Error`	0.00	test_vm_life_cycle.py
ContextSuite context=TestVAppsVM>:setup	`Error`	0.01	test_vm_life_cycle.py
ContextSuite context=TestVMLifeCycle>:setup	`Error`	0.02	test_vm_life_cycle.py
all_test_vm_lifecycle_unmanage_import	`Skipped`	---	test_vm_lifecycle_unmanage_import.py
all_test_vm_lifecycle_with_snapshot_or_volume	`Skipped`	---	test_vm_lifecycle_with_snapshot_or_volume.py
all_test_vm_schedule	`Skipped`	---	test_vm_schedule.py
all_test_vm_snapshot_kvm	`Skipped`	---	test_vm_snapshot_kvm.py
all_test_vm_snapshots	`Skipped`	---	test_vm_snapshots.py
all_test_vm_strict_host_tags	`Skipped`	---	test_vm_strict_host_tags.py
all_test_vnf_templates	`Skipped`	---	test_vnf_templates.py
all_test_volumes	`Skipped`	---	test_volumes.py
all_test_vpc_ipv6	`Skipped`	---	test_vpc_ipv6.py
all_test_vpc_redundant	`Skipped`	---	test_vpc_redundant.py
all_test_vpc_router_nics	`Skipped`	---	test_vpc_router_nics.py
all_test_vpc_vpn	`Skipped`	---	test_vpc_vpn.py
all_test_webhook_delivery	`Skipped`	---	test_webhook_delivery.py
all_test_webhook_lifecycle	`Skipped`	---	test_webhook_lifecycle.py
all_test_host_maintenance	`Skipped`	---	test_host_maintenance.py
all_test_hostha_kvm	`Skipped`	---	test_hostha_kvm.py

blueorangutan · 2025-09-18T08:21:10Z

[SF] Trillian test result (tid-14375)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 56589 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10144-t14375-kvm-ol8.zip
Smoke tests completed. 146 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	1.16	test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster	`Failure`	26.86	test_kubernetes_clusters.py

blueorangutan · 2025-09-18T10:57:05Z

[SF] Trillian test result (tid-14368)
Environment: xcpng82 (x2), zone: Advanced Networking with Mgmt server ol9
Total time taken: 85325 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10144-t14368-xcpng82.zip
Smoke tests completed. 140 look OK, 7 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_events_resource	`Error`	204.29	test_events_resource.py
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	1.17	test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster	`Failure`	56.48	test_kubernetes_clusters.py
test_01_non_strict_host_anti_affinity	`Error`	206.10	test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity	`Error`	49.07	test_nonstrict_affinity_group.py
test_01_primary_storage_iscsi	`Error`	0.78	test_primary_storage.py
test_01_vpn_usage	`Error`	1.10	test_usage.py
test_11_destroy_vm_and_volumes	`Error`	19.88	test_vm_life_cycle.py
test_01_migrate_vm_strict_tags_success	`Error`	54.06	test_vm_strict_host_tags.py

blueorangutan · 2025-09-18T22:01:35Z

[SF] Trillian test result (tid-14377)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 51994 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10144-t14377-kvm-ol8.zip
Smoke tests completed. 146 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	1.15	test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster	`Failure`	26.79	test_kubernetes_clusters.py

DaanHoogland · 2025-09-19T12:55:55Z

@harikrishna-patnala , if you consider these results on par with the healthcheck pr, we can merge. If not, it needs another look.

github-actions · 2025-10-13T11:10:43Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

boring-cyborg bot added component:api component:integration-test component:kvm component:simulator component:storage component:vmware component:XenServer Python Warning... Python code Ahead! labels Dec 28, 2024

jbampton closed this Dec 28, 2024

jbampton reopened this Dec 28, 2024

DaanHoogland approved these changes Dec 28, 2024

View reviewed changes

vishesh92 reviewed Dec 31, 2024

View reviewed changes

.github/linters/codespell.txt Outdated Show resolved Hide resolved

vishesh92 reviewed Dec 31, 2024

View reviewed changes

.github/linters/codespell.txt Outdated Show resolved Hide resolved

vishesh92 reviewed Dec 31, 2024

View reviewed changes

.github/linters/codespell.txt Outdated Show resolved Hide resolved

github-actions bot added the status:has-conflicts label Jan 8, 2025

jbampton mentioned this pull request Mar 29, 2025

scripts(shell): counts of misspelled words in the codebase #10639

Open

pre-commit upgrade codespell and fix spelling

ef08967

jbampton force-pushed the pre-commit-update-codespell branch from b833c07 to ef08967 Compare April 25, 2025 16:27

boring-cyborg bot added component:agent component:hyperv component:networking labels Apr 25, 2025

github-actions bot removed the status:has-conflicts label Apr 25, 2025

github-actions bot added the status:has-conflicts label Sep 17, 2025

Merge branch 'main' into pre-commit-update-codespell

5955128

github-actions bot removed the status:has-conflicts label Sep 17, 2025

github-actions bot added the status:has-conflicts label Sep 17, 2025

Fix conflicts

92bccb3

boring-cyborg bot added component:console-proxy component:virtual-router labels Sep 17, 2025

github-actions bot removed the status:has-conflicts label Sep 17, 2025

github-actions bot added the status:has-conflicts label Oct 13, 2025

pre-commit upgrade codespell; fix spelling; configure gitleaks #10144

Are you sure you want to change the base?

pre-commit upgrade codespell; fix spelling; configure gitleaks #10144

Uh oh!

Conversation

jbampton commented Dec 28, 2024

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov bot commented Dec 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

jbampton commented Dec 28, 2024

Uh oh!

blueorangutan commented Dec 28, 2024

Uh oh!

blueorangutan commented Dec 28, 2024

Uh oh!

DaanHoogland commented Dec 29, 2024

Uh oh!

blueorangutan commented Dec 29, 2024

Uh oh!

blueorangutan commented Dec 29, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 8, 2025

Uh oh!

github-actions bot commented Sep 17, 2025

Uh oh!

DaanHoogland commented Sep 17, 2025

Uh oh!

blueorangutan commented Sep 17, 2025

Uh oh!

blueorangutan commented Sep 17, 2025

Uh oh!

DaanHoogland commented Sep 17, 2025

Uh oh!

blueorangutan commented Sep 17, 2025

Uh oh!

vishesh92 commented Sep 17, 2025

Uh oh!

github-actions bot commented Sep 17, 2025

Uh oh!

jbampton commented Sep 17, 2025

Uh oh!

blueorangutan commented Sep 17, 2025

Uh oh!

blueorangutan commented Sep 18, 2025

Uh oh!

blueorangutan commented Sep 18, 2025

Uh oh!

blueorangutan commented Sep 18, 2025

Uh oh!

DaanHoogland commented Sep 18, 2025

Uh oh!

blueorangutan commented Sep 18, 2025

Uh oh!

blueorangutan commented Sep 18, 2025

Uh oh!

blueorangutan commented Sep 18, 2025

Uh oh!

blueorangutan commented Sep 18, 2025

Uh oh!

blueorangutan commented Sep 18, 2025

Uh oh!

DaanHoogland commented Sep 19, 2025

Uh oh!

github-actions bot commented Oct 13, 2025

codecov bot commented Dec 28, 2024 •

edited

Loading