Accept case insensitive values in boolean settings

[bernardodemarco]

Description

Currently, when updating boolean settings, the Management Server performs a case sensitive validation of the inserted values. Thus, only the true and false values are accepted.

This PR proposes to extend this validation to encompass case insensitive boolean values. Therefore, values such as True and FALSE will be accepted and will be properly normalized before being persisted in the database.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Screenshots (if appropriate):

How Has This Been Tested?

• Verified that it was possible to update the quota.enable.service global setting to FaLsE.

updateConfiguration API execution

(acs-all-in-one) 🦌 > update configuration name="quota.enable.service" value="FaLsE"
{
  "configuration": {
    "category": "Advanced",
    "component": "QUOTA-PLUGIN",
    "defaultvalue": "false",
    "description": "Indicates whether Quota plugin is enabled or not.",
    "displaytext": "Quota enable service",
    "group": "Miscellaneous",
    "isdynamic": true,
    "name": "quota.enable.service",
    "subgroup": "Quota",
    "type": "Boolean",
    "value": "FaLsE"
  }
}

Persisted configuration value in the database

MariaDB [cloud]> select name,value from configuration where name = "quota.enable.service";
+----------------------+-------+
| name                 | value |
+----------------------+-------+
| quota.enable.service | false |
+----------------------+-------+
1 row in set (0.000 sec)

• Verified that it was possible to update the setting value to TRUe:

updateConfiguration API execution

(acs-all-in-one) 🐓 > update configuration name="quota.enable.service" value="TRUe"
{
  "configuration": {
    "category": "Advanced",
    "component": "QUOTA-PLUGIN",
    "defaultvalue": "false",
    "description": "Indicates whether Quota plugin is enabled or not.",
    "displaytext": "Quota enable service",
    "group": "Miscellaneous",
    "isdynamic": true,
    "name": "quota.enable.service",
    "subgroup": "Quota",
    "type": "Boolean",
    "value": "TRUe"
  }
}

Persisted configuration value in the database

MariaDB [cloud]> select name,value from configuration where name = "quota.enable.service";
+----------------------+-------+
| name                 | value |
+----------------------+-------+
| quota.enable.service | true  |
+----------------------+-------+
1 row in set (0.000 sec)

[bernardodemarco]

@blueorangutan package

[blueorangutan]

@bernardodemarco a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Attention: Patch coverage is 80.95238% with 4 lines in your changes missing coverage. Please review.

Project coverage is 16.15%. Comparing base (823080c) to head (466c76d).
Report is 11 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
.../cloud/configuration/ConfigurationManagerImpl.java	80.95%	3 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.20   #10663   +/-   ##
=========================================
  Coverage     16.14%   16.15%           
- Complexity    13253    13273   +20     
=========================================
  Files          5656     5656           
  Lines        497893   497888    -5     
  Branches      60374    60373    -1     
=========================================
+ Hits          80405    80442   +37     
+ Misses       408529   408488   -41     
+ Partials       8959     8958    -1     

Flag	Coverage Δ
uitests	4.00% <ø> (ø)
unittests	17.00% <80.95%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12955

[bernardodemarco]

@blueorangutan package

[blueorangutan]

@bernardodemarco a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13279

[DaanHoogland]

clgtm and unit tests provided. never the less I think this is such a cross cutting concern that it will need extensive testing.

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-13225)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 56037 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10663-t13225-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[erikbocks]

I tested the changes in my local environment and everything worked as expected for booleans, strings, integers, and floats.

[github-actions]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[JoaoJandre]

@bernardodemarco could you fix the merge conflicts here?

[bernardodemarco]

@bernardodemarco could you fix the merge conflicts here?

Sure, done!

[bernardodemarco]

@blueorangutan package

[bernardodemarco]

@DaanHoogland @weizhouapache @Pearl1594, can we run the CI again for this one?

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13612

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-13479)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 54482 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10663-t13479-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File