systemvm: fix failed to get script version when patch system vm or router #10962

weizhouapache · 2025-06-05T12:44:54Z

Description

This PR fixes a regression of #9900

prior to this PR

2025-06-05 12:28:53,992 DEBUG [cloud.agent.Agent] (AgentRequest-Handler-1:[]) (logid:) Processing command: com.cloud.agent.api.PatchSystemVmCommand
2025-06-05 12:29:25,959 DEBUG [resource.wrapper.LibvirtPatchSystemVmCommandWrapper] (AgentRequest-Handler-1:[]) (logid:) Patch result of systemVM s-368-VM: /root
2025-06-05 12:29:25,961 WARN  [resource.wrapper.LibvirtPatchSystemVmCommandWrapper] (AgentRequest-Handler-1:[]) (logid:) Failed to get the latest script version
2025-06-05 12:29:25,962 DEBUG [cloud.agent.Agent] (AgentRequest-Handler-1:[]) (logid:) Seq 2-7450361158554357406:  { Ans: , MgmtId: 32986204472275, via: 2, Ver: v1, Flags: 10, [{"com.cloud.agent.api.PatchSystemVmAnswer":{"templateVersion":"Cloudstack Release 4.20.1 Wed May 14 05:22:13 PM UTC 2025","scriptsVersion":"5ebc6ded1a3880732363c1cdbbd54cfb

with this PR

2025-06-05 12:42:46,219 DEBUG [cloud.agent.Agent] (AgentRequest-Handler-2:[]) (logid:) Request:Seq 2-7450361158554357463:  { Cmd , MgmtId: 32986204472275, via: 2, Ver: v1, Flags: 100011, [{"com.cloud.agent.api.PatchSystemVmCommand":{"forced":"true","accessDetails":{"router.ip":"169.254.151.188","router.name":"s-368-VM"},"wait":"0","bypassHostMaintenance":"false"}}] }
2025-06-05 12:42:46,220 DEBUG [cloud.agent.Agent] (AgentRequest-Handler-2:[]) (logid:) Processing command: com.cloud.agent.api.PatchSystemVmCommand
2025-06-05 12:43:18,083 DEBUG [resource.wrapper.LibvirtPatchSystemVmCommandWrapper] (AgentRequest-Handler-2:[]) (logid:) Patch result of systemVM s-368-VM: /root
2025-06-05 12:43:18,083 DEBUG [cloud.agent.Agent] (AgentRequest-Handler-2:[]) (logid:) Seq 2-7450361158554357463:  { Ans: , MgmtId: 32986204472275, via: 2, Ver: v1, Flags: 10, [{"com.cloud.agent.api.PatchSystemVmAnswer":{"templateVersion":"Cloudstack Release 4.20.1 Wed May 14 05:22:13 PM UTC 2025","scriptsVersion":"5ebc6ded1a3880732363c1cdbbd54cfb","result":"true","details":"Successfully patched systemVM s-368-VM ","wait":"0","bypassHostMaintenance":"false"}}] }

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

…uter This is a regression of apache#9900 prior to this PR ``` 2025-06-05 12:28:53,992 DEBUG [cloud.agent.Agent] (AgentRequest-Handler-1:[]) (logid:) Processing command: com.cloud.agent.api.PatchSystemVmCommand 2025-06-05 12:29:25,959 DEBUG [resource.wrapper.LibvirtPatchSystemVmCommandWrapper] (AgentRequest-Handler-1:[]) (logid:) Patch result of systemVM s-368-VM: /root 2025-06-05 12:29:25,961 WARN [resource.wrapper.LibvirtPatchSystemVmCommandWrapper] (AgentRequest-Handler-1:[]) (logid:) Failed to get the latest script version 2025-06-05 12:29:25,962 DEBUG [cloud.agent.Agent] (AgentRequest-Handler-1:[]) (logid:) Seq 2-7450361158554357406: { Ans: , MgmtId: 32986204472275, via: 2, Ver: v1, Flags: 10, [{"com.cloud.agent.api.PatchSystemVmAnswer":{"templateVersion":"Cloudstack Release 4.20.1 Wed May 14 05:22:13 PM UTC 2025","scriptsVersion":"5ebc6ded1a3880732363c1cdbbd54cfb ``` with this PR ``` 2025-06-05 12:42:46,219 DEBUG [cloud.agent.Agent] (AgentRequest-Handler-2:[]) (logid:) Request:Seq 2-7450361158554357463: { Cmd , MgmtId: 32986204472275, via: 2, Ver: v1, Flags: 100011, [{"com.cloud.agent.api.PatchSystemVmCommand":{"forced":"true","accessDetails":{"router.ip":"169.254.151.188","router.name":"s-368-VM"},"wait":"0","bypassHostMaintenance":"false"}}] } 2025-06-05 12:42:46,220 DEBUG [cloud.agent.Agent] (AgentRequest-Handler-2:[]) (logid:) Processing command: com.cloud.agent.api.PatchSystemVmCommand 2025-06-05 12:43:18,083 DEBUG [resource.wrapper.LibvirtPatchSystemVmCommandWrapper] (AgentRequest-Handler-2:[]) (logid:) Patch result of systemVM s-368-VM: /root 2025-06-05 12:43:18,083 DEBUG [cloud.agent.Agent] (AgentRequest-Handler-2:[]) (logid:) Seq 2-7450361158554357463: { Ans: , MgmtId: 32986204472275, via: 2, Ver: v1, Flags: 10, [{"com.cloud.agent.api.PatchSystemVmAnswer":{"templateVersion":"Cloudstack Release 4.20.1 Wed May 14 05:22:13 PM UTC 2025","scriptsVersion":"5ebc6ded1a3880732363c1cdbbd54cfb","result":"true","details":"Successfully patched systemVM s-368-VM ","wait":"0","bypassHostMaintenance":"false"}}] } ```

codecov · 2025-06-05T12:53:00Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 16.17%. Comparing base (7044564) to head (c029196).
⚠️ Report is 29 commits behind head on 4.20.

Additional details and impacted files

@@            Coverage Diff            @@
##               4.20   #10962   +/-   ##
=========================================
  Coverage     16.17%   16.17%           
- Complexity    13293    13295    +2     
=========================================
  Files          5656     5656           
  Lines        498098   498098           
  Branches      60423    60423           
=========================================
+ Hits          80568    80571    +3     
+ Misses       408562   408560    -2     
+ Partials       8968     8967    -1

Flag	Coverage Δ
uitests	`4.00% <ø> (ø)`
unittests	`17.02% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

weizhouapache · 2025-07-07T11:37:40Z

@blueorangutan package

blueorangutan · 2025-07-07T11:40:04Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-07-07T13:06:22Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14068

weizhouapache · 2025-07-07T17:27:12Z

@blueorangutan test

blueorangutan · 2025-07-07T17:28:04Z

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-07-08T07:33:52Z

[SF] Trillian test result (tid-13708)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 48111 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10962-t13708-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

systemvm/patch-sysvms.sh

Copilot

Pull Request Overview

This PR addresses a regression where patching system VMs or routers failed to retrieve the latest script version by refining the keystore import logic in the patch script.

Restricts global cacerts import to only consoleproxy and secstorage types
Suppresses keytool stderr output to reduce log noise

systemvm/patch-sysvms.sh

sureshanaparti

clgtm

DaanHoogland

clgtm

weizhouapache · 2025-09-10T09:11:23Z

@blueorangutan package

blueorangutan · 2025-09-10T09:12:07Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-09-10T10:46:56Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14931

weizhouapache · 2025-09-12T06:50:14Z

@kiranchavala
can you please test this PR when you have time ? thanks

weizhouapache · 2025-09-15T15:07:25Z

moving to 4.20.3 due to inactivity

shwstppr · 2025-09-26T05:30:37Z

@blueorangutan package

blueorangutan · 2025-09-26T05:32:04Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

shwstppr

LGTM. Tested patch operation with and without script changes,

Before,

[root@ref-trl-5997-k-Mr9-abhishek-kumar-kvm1 ~]# tail -f /var/log/cloudstack/agent/agent.log | grep -i "patch"
2025-09-26 06:49:02,567 DEBUG [cloud.agent.Agent] (AgentRequest-Handler-2:[]) (logid:) Request:Seq 1-4092364686396374076:  { Cmd , MgmtId: 32988435843878, via: 1, Ver: v1, Flags: 100011, [{"com.cloud.agent.api.PatchSystemVmCommand":{"forced":"true","accessDetails":{"router.ip":"169.254.50.99","router.name":"v-5-VM"},"wait":"0","bypassHostMaintenance":"false"}}] }
2025-09-26 06:49:02,568 DEBUG [cloud.agent.Agent] (AgentRequest-Handler-2:[]) (logid:) Processing command: com.cloud.agent.api.PatchSystemVmCommand
2025-09-26 06:49:31,951 DEBUG [resource.wrapper.LibvirtPatchSystemVmCommandWrapper] (AgentRequest-Handler-2:[]) (logid:) Patch result of systemVM v-5-VM: /root
2025-09-26 06:49:31,953 WARN  [resource.wrapper.LibvirtPatchSystemVmCommandWrapper] (AgentRequest-Handler-2:[]) (logid:) Failed to get the latest script version
2025-09-26 06:49:31,953 DEBUG [cloud.agent.Agent] (AgentRequest-Handler-2:[]) (logid:) Seq 1-4092364686396374076:  { Ans: , MgmtId: 32988435843878, via: 1, Ver: v1, Flags: 10, [{"com.cloud.agent.api.PatchSystemVmAnswer":{"templateVersion":"Cloudstack Release 4.20.1 Wed May 28 06:10:04 AM UTC 2025","scriptsVersion":"b4448303d00dcfb38ffb30b071fd3891
","result":"true","details":"Successfully patched systemVM v-5-VM ","wait":"0","bypassHostMaintenance":"false"}}] }

After making changes to the script on my existing env KVM host (patched CPVM, SSVM VR),
No errors/warnings seen

[root@ref-trl-5997-k-Mr9-abhishek-kumar-kvm1 ~]# tail -f /var/log/cloudstack/agent/agent.log | grep -i "patch"
2025-09-26 06:53:26,216 DEBUG [cloud.agent.Agent] (AgentRequest-Handler-1:[]) (logid:) Request:Seq 1-4092364686396374106:  { Cmd , MgmtId: 32988435843878, via: 1, Ver: v1, Flags: 100011, [{"com.cloud.agent.api.PatchSystemVmCommand":{"forced":"true","accessDetails":{"router.ip":"169.254.50.99","router.name":"v-5-VM"},"wait":"0","bypassHostMaintenance":"false"}}] }
2025-09-26 06:53:26,216 DEBUG [cloud.agent.Agent] (AgentRequest-Handler-1:[]) (logid:) Processing command: com.cloud.agent.api.PatchSystemVmCommand
2025-09-26 06:53:56,683 DEBUG [resource.wrapper.LibvirtPatchSystemVmCommandWrapper] (AgentRequest-Handler-1:[]) (logid:) Patch result of systemVM v-5-VM: /root
2025-09-26 06:53:56,683 DEBUG [cloud.agent.Agent] (AgentRequest-Handler-1:[]) (logid:) Seq 1-4092364686396374106:  { Ans: , MgmtId: 32988435843878, via: 1, Ver: v1, Flags: 10, [{"com.cloud.agent.api.PatchSystemVmAnswer":{"templateVersion":"Cloudstack Release 4.20.1 Wed May 28 06:10:04 AM UTC 2025","scriptsVersion":"b4448303d00dcfb38ffb30b071fd3891","result":"true","details":"Successfully patched systemVM v-5-VM ","wait":"0","bypassHostMaintenance":"false"}}] }
2025-09-26 06:55:07,444 DEBUG [cloud.agent.Agent] (AgentRequest-Handler-5:[]) (logid:) Request:Seq 1-4092364686396374116:  { Cmd , MgmtId: 32988435843878, via: 1, Ver: v1, Flags: 100011, [{"com.cloud.agent.api.PatchSystemVmCommand":{"forced":"true","accessDetails":{"router.ip":"169.254.233.55","router.name":"s-1-VM"},"wait":"0","bypassHostMaintenance":"false"}}] }
2025-09-26 06:55:07,444 DEBUG [cloud.agent.Agent] (AgentRequest-Handler-5:[]) (logid:) Processing command: com.cloud.agent.api.PatchSystemVmCommand
2025-09-26 06:56:06,441 DEBUG [resource.wrapper.LibvirtPatchSystemVmCommandWrapper] (AgentRequest-Handler-5:[]) (logid:) Patch result of systemVM s-1-VM: /root
2025-09-26 06:56:06,442 DEBUG [cloud.agent.Agent] (AgentRequest-Handler-5:[]) (logid:) Seq 1-4092364686396374116:  { Ans: , MgmtId: 32988435843878, via: 1, Ver: v1, Flags: 10, [{"com.cloud.agent.api.PatchSystemVmAnswer":{"templateVersion":"Cloudstack Release 4.20.1 Wed May 28 06:10:04 AM UTC 2025","scriptsVersion":"b4448303d00dcfb38ffb30b071fd3891","result":"true","details":"Successfully patched systemVM s-1-VM ","wait":"0","bypassHostMaintenance":"false"}}] }
2025-09-26 06:56:50,668 DEBUG [cloud.agent.Agent] (AgentRequest-Handler-1:[]) (logid:) Request:Seq 1-4092364686396374121:  { Cmd , MgmtId: 32988435843878, via: 1, Ver: v1, Flags: 100011, [{"com.cloud.agent.api.PatchSystemVmCommand":{"forced":"true","accessDetails":{"router.ip":"169.254.255.19","router.name":"r-4-VM"},"wait":"0","bypassHostMaintenance":"false"}}] }
2025-09-26 06:56:50,668 DEBUG [cloud.agent.Agent] (AgentRequest-Handler-1:[]) (logid:) Processing command: com.cloud.agent.api.PatchSystemVmCommand
2025-09-26 06:57:17,328 DEBUG [resource.wrapper.LibvirtPatchSystemVmCommandWrapper] (AgentRequest-Handler-1:[]) (logid:) Patch result of systemVM r-4-VM: version:b4448303d00dcfb38ffb30b071fd3891 
2025-09-26 06:57:17,329 DEBUG [cloud.agent.Agent] (AgentRequest-Handler-1:[]) (logid:) Seq 1-4092364686396374121:  { Ans: , MgmtId: 32988435843878, via: 1, Ver: v1, Flags: 10, [{"com.cloud.agent.api.PatchSystemVmAnswer":{"templateVersion":"Cloudstack Release 4.20.1 Wed May 28 06:10:04 AM UTC 2025","scriptsVersion":"b4448303d00dcfb38ffb30b071fd3891","result":"true","details":"Successfully patched systemVM r-4-VM ","wait":"0","bypassHostMaintenance":"false"}}] }

blueorangutan · 2025-09-26T07:07:04Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15178

weizhouapache · 2025-09-26T07:09:34Z

thanks @shwstppr !

weizhouapache · 2025-09-26T07:09:55Z

@blueorangutan test

blueorangutan · 2025-09-26T07:10:03Z

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-09-26T23:04:02Z

[SF] Trillian test result (tid-14444)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 54181 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10962-t14444-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

…uter (apache#10962) This is a regression of apache#9900 prior to this PR ``` 2025-06-05 12:28:53,992 DEBUG [cloud.agent.Agent] (AgentRequest-Handler-1:[]) (logid:) Processing command: com.cloud.agent.api.PatchSystemVmCommand 2025-06-05 12:29:25,959 DEBUG [resource.wrapper.LibvirtPatchSystemVmCommandWrapper] (AgentRequest-Handler-1:[]) (logid:) Patch result of systemVM s-368-VM: /root 2025-06-05 12:29:25,961 WARN [resource.wrapper.LibvirtPatchSystemVmCommandWrapper] (AgentRequest-Handler-1:[]) (logid:) Failed to get the latest script version 2025-06-05 12:29:25,962 DEBUG [cloud.agent.Agent] (AgentRequest-Handler-1:[]) (logid:) Seq 2-7450361158554357406: { Ans: , MgmtId: 32986204472275, via: 2, Ver: v1, Flags: 10, [{"com.cloud.agent.api.PatchSystemVmAnswer":{"templateVersion":"Cloudstack Release 4.20.1 Wed May 14 05:22:13 PM UTC 2025","scriptsVersion":"5ebc6ded1a3880732363c1cdbbd54cfb ``` with this PR ``` 2025-06-05 12:42:46,219 DEBUG [cloud.agent.Agent] (AgentRequest-Handler-2:[]) (logid:) Request:Seq 2-7450361158554357463: { Cmd , MgmtId: 32986204472275, via: 2, Ver: v1, Flags: 100011, [{"com.cloud.agent.api.PatchSystemVmCommand":{"forced":"true","accessDetails":{"router.ip":"169.254.151.188","router.name":"s-368-VM"},"wait":"0","bypassHostMaintenance":"false"}}] } 2025-06-05 12:42:46,220 DEBUG [cloud.agent.Agent] (AgentRequest-Handler-2:[]) (logid:) Processing command: com.cloud.agent.api.PatchSystemVmCommand 2025-06-05 12:43:18,083 DEBUG [resource.wrapper.LibvirtPatchSystemVmCommandWrapper] (AgentRequest-Handler-2:[]) (logid:) Patch result of systemVM s-368-VM: /root 2025-06-05 12:43:18,083 DEBUG [cloud.agent.Agent] (AgentRequest-Handler-2:[]) (logid:) Seq 2-7450361158554357463: { Ans: , MgmtId: 32986204472275, via: 2, Ver: v1, Flags: 10, [{"com.cloud.agent.api.PatchSystemVmAnswer":{"templateVersion":"Cloudstack Release 4.20.1 Wed May 14 05:22:13 PM UTC 2025","scriptsVersion":"5ebc6ded1a3880732363c1cdbbd54cfb","result":"true","details":"Successfully patched systemVM s-368-VM ","wait":"0","bypassHostMaintenance":"false"}}] } ```

DaanHoogland added this to the 4.19.4 milestone Jun 9, 2025

sureshanaparti reviewed Jul 8, 2025

View reviewed changes

systemvm/patch-sysvms.sh Show resolved Hide resolved

sureshanaparti requested a review from Copilot July 8, 2025 08:26

Copilot AI reviewed Jul 8, 2025

View reviewed changes

systemvm/patch-sysvms.sh Show resolved Hide resolved

systemvm/patch-sysvms.sh Show resolved Hide resolved

weizhouapache marked this pull request as ready for review July 11, 2025 00:08

sureshanaparti reviewed Jul 15, 2025

View reviewed changes

sureshanaparti approved these changes Jul 15, 2025

View reviewed changes

sureshanaparti requested review from DaanHoogland and Pearl1594 July 15, 2025 12:19

DaanHoogland approved these changes Jul 15, 2025

View reviewed changes

weizhouapache modified the milestones: 4.19.4, 4.20.2 Sep 2, 2025

weizhouapache changed the base branch from 4.19 to 4.20 September 10, 2025 09:10

Merge branch '4.20' into 4.19-systemvm-failed-to-get-script-version

c029196

weizhouapache modified the milestones: 4.20.2, 4.20.3 Sep 15, 2025

weizhouapache added this to the 4.20.2 milestone Sep 18, 2025

shwstppr approved these changes Sep 26, 2025

View reviewed changes

weizhouapache merged commit 5dfeb79 into apache:4.20 Sep 26, 2025
26 checks passed

DaanHoogland deleted the 4.19-systemvm-failed-to-get-script-version branch September 29, 2025 10:58

Uh oh!

systemvm: fix failed to get script version when patch system vm or router #10962

systemvm: fix failed to get script version when patch system vm or router #10962

Uh oh!

Conversation

weizhouapache commented Jun 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov bot commented Jun 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

weizhouapache commented Jul 7, 2025

Uh oh!

blueorangutan commented Jul 7, 2025

Uh oh!

blueorangutan commented Jul 7, 2025

Uh oh!

weizhouapache commented Jul 7, 2025

Uh oh!

blueorangutan commented Jul 7, 2025

Uh oh!

blueorangutan commented Jul 8, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

weizhouapache commented Sep 10, 2025

Uh oh!

blueorangutan commented Sep 10, 2025

Uh oh!

blueorangutan commented Sep 10, 2025

Uh oh!

weizhouapache commented Sep 12, 2025

Uh oh!

weizhouapache commented Sep 15, 2025

Uh oh!

shwstppr commented Sep 26, 2025

Uh oh!

blueorangutan commented Sep 26, 2025

Uh oh!

shwstppr left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Sep 26, 2025

Uh oh!

weizhouapache commented Sep 26, 2025

Uh oh!

weizhouapache commented Sep 26, 2025

Uh oh!

blueorangutan commented Sep 26, 2025

Uh oh!

blueorangutan commented Sep 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

weizhouapache commented Jun 5, 2025 •

edited

Loading

codecov bot commented Jun 5, 2025 •

edited

Loading