Switch to jdk18on bouncycastle jars #11201

harikrishna-patnala · 2025-07-15T11:08:56Z

Description

This PR fixes #10954

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Updated my environment with the newer jars and everything seems fine

How did you try to break this feature and the system with this change?

harikrishna-patnala · 2025-07-15T11:10:32Z

@blueorangutan package

blueorangutan · 2025-07-15T11:12:06Z

@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2025-07-15T11:16:48Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.38%. Comparing base (b0c7719) to head (6138c02).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #11201   +/-   ##
=========================================
  Coverage     17.38%   17.38%           
+ Complexity    15282    15281    -1     
=========================================
  Files          5891     5891           
  Lines        526356   526356           
  Branches      64270    64270           
=========================================
  Hits          91526    91526           
- Misses       424488   424489    +1     
+ Partials      10342    10341    -1

Flag	Coverage Δ
uitests	`3.61% <ø> (ø)`
unittests	`18.43% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

blueorangutan · 2025-07-15T12:24:47Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14192

DaanHoogland · 2025-07-15T13:37:45Z

@blueorangutan test matrix

blueorangutan · 2025-07-15T13:40:04Z

@DaanHoogland a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests

blueorangutan · 2025-07-15T14:39:06Z

[SF] Trillian Build Failed (tid-13786)

blueorangutan · 2025-07-15T14:39:32Z

[SF] Trillian Build Failed (tid-13784)

blueorangutan · 2025-07-15T14:44:47Z

[SF] Trillian Build Failed (tid-13785)

blueorangutan · 2025-07-15T14:51:31Z

[SF] Trillian Build Failed (tid-13783)

harikrishna-patnala · 2025-07-17T04:57:22Z

@blueorangutan test matrix

blueorangutan · 2025-07-17T04:58:04Z

@harikrishna-patnala a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests

blueorangutan · 2025-07-17T05:55:42Z

[SF] Trillian Build Failed (tid-13806)

blueorangutan · 2025-07-17T05:57:11Z

[SF] Trillian Build Failed (tid-13808)

blueorangutan · 2025-07-17T06:03:00Z

[SF] Trillian Build Failed (tid-13807)

blueorangutan · 2025-07-17T06:09:33Z

[SF] Trillian Build Failed (tid-13805)

harikrishna-patnala · 2025-07-18T09:08:43Z

@blueorangutan package

blueorangutan · 2025-07-18T09:10:06Z

@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

harikrishna-patnala · 2025-07-18T09:19:39Z

@weizhouapache @DaanHoogland

The available versions for bouncy castle provider supporting jdk18 starts from 1.71 to 1.81 (https://mvnrepository.com/artifact/org.bouncycastle/bcprov-jdk18on)

If we use 1.81 as the provider version

<cs.bcprov.version>1.81</cs.bcprov.version>

SystemVMs have trouble starting with the error

Caused by: java.lang.NoClassDefFoundError: Could not initialize class org.bouncycastle.operator.jcajce.OperatorHelper
        at org.bouncycastle.operator.jcajce.JcaContentSignerBuilder.<init>(Unknown Source)
        at org.apache.cloudstack.utils.security.CertUtils.generateV3Certificate(CertUtils.java:241)
        at org.apache.cloudstack.ca.provider.RootCAProvider.generateCertificate(RootCAProvider.java:152)

The last version that worked with our code is

<cs.bcprov.version>1.72</cs.bcprov.version>

At the moment I don't know the reason for "OperatorHelper" class not being found, so I adjusted the code to use 1.72 version. I'm not sure how the mentioned vulnerabilities effects us https://mvnrepository.com/artifact/org.bouncycastle/bcprov-jdk18on/1.72

Please review and see if this is fine.

blueorangutan · 2025-07-18T10:01:53Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 14254

vishesh92

clgtm

blueorangutan · 2025-07-18T12:52:36Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 14256

weizhouapache · 2025-07-19T01:55:49Z

pom.xml

        <cs.axis2.version>1.6.4</cs.axis2.version>
        <cs.batik.version>1.14</cs.batik.version>
-        <cs.bcprov.version>1.70</cs.bcprov.version>
+        <cs.bcprov.version>1.72</cs.bcprov.version>


According to central mvn repo, 1.72 has 5 vulnerabilities, 1.81 is the latest

It seems here are some imcompatibility issue with 1.81, I think it can be fixed

@harikrishna-patnala check if the issues with 1.81 can be fixed or not

I've tried multiple ways to use 1.81 and rewriting code for getting X509Certificate but still facing the same issue. Can someone of you help me here @weizhouapache @sureshanaparti

DaanHoogland · 2025-07-30T14:24:39Z

I ran mvn dependency:tree and found

[INFO] +- org.opensaml:opensaml:jar:2.6.6:compile # updating -> 4.0.1
[INFO] |  +- org.opensaml:openws:jar:1.5.6:compile
[INFO] |  |  \- org.opensaml:xmltooling:jar:1.4.6:compile
[INFO] |  |     +- org.bouncycastle:bcprov-jdk15on:jar:1.51:compile

[INFO] +- io.minio:minio:jar:8.5.2:compile # updating -> 8.2.17
[INFO] |  +- org.bouncycastle:bcprov-jdk15on:jar:1.69:compile

[INFO] +- org.apache.directory.server:apacheds-core:jar:2.0.0.AM25:test # unpdating -> 2.0.0AM27
[INFO] |  \- org.bouncycastle:bcprov-jdk15on:jar:1.59:compile

DaanHoogland · 2025-07-30T15:06:09Z

after upgrading packages to latest:

[INFO] |  +- org.opensaml:opensaml-security-api:jar:4.0.1:compile
[INFO] |  |  +- org.bouncycastle:bcprov-jdk15on:jar:1.64:compile

[INFO] +- org.apache.directory.server:apacheds-core:jar:2.0.0.AM27:test
[INFO] |  +- org.bouncycastle:bcprov-jdk15on:jar:1.70:compile

pom.xml

weizhouapache · 2025-09-25T07:34:57Z

@blueorangutan package

blueorangutan · 2025-09-25T07:36:04Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

weizhouapache · 2025-09-25T08:44:22Z

after upgrading packages to latest:

[INFO] |  +- org.opensaml:opensaml-security-api:jar:4.0.1:compile
[INFO] |  |  +- org.bouncycastle:bcprov-jdk15on:jar:1.64:compile

[INFO] +- org.apache.directory.server:apacheds-core:jar:2.0.0.AM27:test
[INFO] |  +- org.bouncycastle:bcprov-jdk15on:jar:1.70:compile

yes, this PR has large impact on ldap and saml

blueorangutan · 2025-09-25T09:08:50Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15162

boring-cyborg bot added component:build component:console-proxy component:kubernetes labels Jul 15, 2025

vishesh92 approved these changes Jul 18, 2025

View reviewed changes

harikrishna-patnala closed this Jul 18, 2025

harikrishna-patnala reopened this Jul 18, 2025

weizhouapache reviewed Jul 19, 2025

View reviewed changes

sureshanaparti requested a review from DaanHoogland July 20, 2025 15:47

sureshanaparti linked an issue Jul 25, 2025 that may be closed by this pull request

[Security] switch to jdk18on bouncycastle jars #10954

Open

sureshanaparti assigned DaanHoogland Jul 25, 2025

DaanHoogland marked this pull request as draft July 30, 2025 16:20

DaanHoogland removed their assignment Jul 31, 2025

weizhouapache added this to the 4.22.0 milestone Aug 21, 2025

weizhouapache mentioned this pull request Aug 21, 2025

Switch BouncyCastle dependencies to jdk18on for improved security #11034

Closed

14 tasks

weizhouapache changed the base branch from 4.19 to main September 25, 2025 07:32

harikrishna-patnala added 2 commits September 25, 2025 09:32

switch to jdk18on bouncycastle jars

630ea7b

Version change

3622353

weizhouapache force-pushed the switchBouncyCastleJars branch from 4b4a305 to 3622353 Compare September 25, 2025 07:32

weizhouapache reviewed Sep 25, 2025

View reviewed changes

pom.xml Outdated Show resolved Hide resolved

Update bcprov to 1.82 in pom.xml

6138c02

Switch to jdk18on bouncycastle jars #11201

Are you sure you want to change the base?

Switch to jdk18on bouncycastle jars #11201

Conversation

harikrishna-patnala commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

harikrishna-patnala commented Jul 15, 2025

Uh oh!

blueorangutan commented Jul 15, 2025

Uh oh!

codecov bot commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Jul 15, 2025

Uh oh!

DaanHoogland commented Jul 15, 2025

Uh oh!

blueorangutan commented Jul 15, 2025

Uh oh!

blueorangutan commented Jul 15, 2025

Uh oh!

blueorangutan commented Jul 15, 2025

Uh oh!

blueorangutan commented Jul 15, 2025

Uh oh!

blueorangutan commented Jul 15, 2025

Uh oh!

harikrishna-patnala commented Jul 17, 2025

Uh oh!

blueorangutan commented Jul 17, 2025

Uh oh!

blueorangutan commented Jul 17, 2025

Uh oh!

blueorangutan commented Jul 17, 2025

Uh oh!

blueorangutan commented Jul 17, 2025

Uh oh!

blueorangutan commented Jul 17, 2025

Uh oh!

harikrishna-patnala commented Jul 18, 2025

Uh oh!

blueorangutan commented Jul 18, 2025

Uh oh!

harikrishna-patnala commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blueorangutan commented Jul 18, 2025

Uh oh!

vishesh92 left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Jul 18, 2025

Uh oh!

weizhouapache Jul 19, 2025

Choose a reason for hiding this comment

Uh oh!

sureshanaparti Jul 20, 2025

Choose a reason for hiding this comment

Uh oh!

harikrishna-patnala Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Jul 30, 2025

Uh oh!

DaanHoogland commented Jul 30, 2025

Uh oh!

Uh oh!

weizhouapache commented Sep 25, 2025

Uh oh!

blueorangutan commented Sep 25, 2025

Uh oh!

harikrishna-patnala commented Jul 15, 2025 •

edited

Loading

codecov bot commented Jul 15, 2025 •

edited

Loading

harikrishna-patnala commented Jul 18, 2025 •

edited

Loading

harikrishna-patnala Jul 23, 2025 •

edited

Loading