Fix spelling in Java and Python files; update the ignored words list `codespell.txt` #11285

jbampton · 2025-07-24T11:49:49Z

Update codespell.txt remove excetion

Description

This PR fixes a simple typo in the exception messages.

Hoping simple fixes can be merged quickly. Let us move faster 🚀

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Update codespell.txt remove `excetion`

codecov · 2025-07-24T11:57:26Z

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.39%. Comparing base (96ccd7e) to head (17df98b).
⚠️ Report is 18 commits behind head on main.

Files with missing lines	Patch %	Lines
...n/java/com/cloud/storage/VolumeApiServiceImpl.java	0.00%	4 Missing ⚠️
...a/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java	0.00%	4 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #11285      +/-   ##
============================================
- Coverage     17.39%   17.39%   -0.01%     
+ Complexity    15283    15280       -3     
============================================
  Files          5889     5889              
  Lines        526141   526141              
  Branches      64234    64234              
============================================
- Hits          91542    91532      -10     
- Misses       424265   424275      +10     
  Partials      10334    10334

Flag	Coverage Δ
uitests	`3.62% <ø> (ø)`
unittests	`18.44% <0.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sureshanaparti · 2025-07-24T12:26:32Z

@blueorangutan package

blueorangutan · 2025-07-24T12:28:03Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-07-24T14:19:32Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14350

DaanHoogland

I like the change, but would like to take the chance to also change

the use of the generic RuntimeException and replace it with our own
replace the repetitive message to messages specific to the jobs

server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java

server/src/main/java/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java

DaanHoogland · 2025-07-25T07:42:43Z

@weizhouapache @JoaoJandre @sureshanaparti (and others) what do you think;

I like the change, but would like to take the chance to also change

the use of the generic RuntimeException and replace it with our own

replace the repetitive message to messages specific to the jobs

.github/linters/codespell.txt

DaanHoogland · 2025-08-08T09:35:16Z

@jbampton , if you are alright with the suggested changes, we can apply those and test??

JoaoJandre · 2025-08-08T11:59:53Z

@weizhouapache @JoaoJandre @sureshanaparti (and others) what do you think;

I like the change, but would like to take the chance to also change

the use of the generic RuntimeException and replace it with our own

replace the repetitive message to messages specific to the jobs

I'm +1 with your suggestion @DaanHoogland

DaanHoogland · 2025-08-11T08:00:24Z

ping @jbampton ?

…pl.java Co-authored-by: dahn <[email protected]>

Co-authored-by: dahn <[email protected]>

…pl.java Co-authored-by: dahn <[email protected]>

jbampton · 2025-08-12T09:58:56Z

@jbampton , if you are alright with the suggested changes, we can apply those and test??

Done now @DaanHoogland thanks

DaanHoogland · 2025-08-12T12:18:13Z

@weizhouapache I agree with #11285 (comment) but would like to leave it out of scope here…?

jbampton · 2025-09-16T17:17:45Z

@weizhouapache I agree with #11285 (comment) but would like to leave it out of scope here…?

Fixed now @DaanHoogland and @weizhouapache I have removed the misspelled words from our ignored words list codespell.txt. So we won't need to fix this again as pre-commit will check and enforce it.

DaanHoogland · 2025-09-17T06:04:42Z

@blueorangutan package

blueorangutan · 2025-09-17T06:06:04Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-09-17T07:37:34Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15050

DaanHoogland · 2025-09-17T12:06:55Z

@blueorangutan test

blueorangutan · 2025-09-17T12:08:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-09-17T13:04:03Z

[SF] Trillian Build Failed (tid-14371)

DaanHoogland · 2025-09-17T15:23:29Z

did an upgrade test

Fix the same typo in 8 Java exception messages

8878688

Update codespell.txt remove `excetion`

boring-cyborg bot added the component:storage label Jul 24, 2025

sureshanaparti approved these changes Jul 24, 2025

View reviewed changes

DaanHoogland reviewed Jul 25, 2025

View reviewed changes

shwstppr approved these changes Jul 28, 2025

View reviewed changes

weizhouapache reviewed Aug 8, 2025

View reviewed changes

.github/linters/codespell.txt Outdated Show resolved Hide resolved

jbampton and others added 8 commits August 12, 2025 19:57

Update server/src/main/java/com/cloud/vm/snapshot/VMSnapshotManagerIm…

f716a35

…pl.java Co-authored-by: dahn <[email protected]>

Update server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java

1eb3f65

Co-authored-by: dahn <[email protected]>

Update server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java

93d9d2e

Co-authored-by: dahn <[email protected]>

Update server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java

0107cf3

Co-authored-by: dahn <[email protected]>

Update server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java

3687703

Co-authored-by: dahn <[email protected]>

Update server/src/main/java/com/cloud/vm/snapshot/VMSnapshotManagerIm…

f2a60f1

…pl.java Co-authored-by: dahn <[email protected]>

Update server/src/main/java/com/cloud/vm/snapshot/VMSnapshotManagerIm…

1eafbe6

…pl.java Co-authored-by: dahn <[email protected]>

Update server/src/main/java/com/cloud/vm/snapshot/VMSnapshotManagerIm…

53e5375

…pl.java Co-authored-by: dahn <[email protected]>

Merge branch 'main' into excetion-typo-fix

6e6326a

DaanHoogland added the status:ready-for-merge label Aug 12, 2025

jbampton and others added 2 commits September 17, 2025 02:54

Merge branch 'main' into excetion-typo-fix

54416ba

Update ignored words list codespell.txt; fix spelling

17df98b

boring-cyborg bot added the Python Warning... Python code Ahead! label Sep 16, 2025

jbampton changed the title ~~Fix the same typo in 8 Java exception messages~~ Fix spelling in Java and Python files; update the ignored words list codespell.txt Sep 16, 2025

DaanHoogland approved these changes Sep 17, 2025

View reviewed changes

DaanHoogland merged commit 6eb27da into apache:main Sep 17, 2025
24 of 26 checks passed

jbampton deleted the excetion-typo-fix branch September 17, 2025 19:45

Fix spelling in Java and Python files; update the ignored words list codespell.txt #11285

Fix spelling in Java and Python files; update the ignored words list codespell.txt #11285

Uh oh!

Conversation

jbampton commented Jul 24, 2025

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov bot commented Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sureshanaparti commented Jul 24, 2025

Uh oh!

blueorangutan commented Jul 24, 2025

Uh oh!

blueorangutan commented Jul 24, 2025

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DaanHoogland commented Jul 25, 2025

Uh oh!

Uh oh!

DaanHoogland commented Aug 8, 2025

Uh oh!

JoaoJandre commented Aug 8, 2025

Uh oh!

DaanHoogland commented Aug 11, 2025

Uh oh!

jbampton commented Aug 12, 2025

Uh oh!

DaanHoogland commented Aug 12, 2025

Uh oh!

jbampton commented Sep 16, 2025

Uh oh!

DaanHoogland commented Sep 17, 2025

Uh oh!

blueorangutan commented Sep 17, 2025

Uh oh!

blueorangutan commented Sep 17, 2025

Uh oh!

DaanHoogland commented Sep 17, 2025

Uh oh!

blueorangutan commented Sep 17, 2025

Uh oh!

blueorangutan commented Sep 17, 2025

Uh oh!

DaanHoogland commented Sep 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Fix spelling in Java and Python files; update the ignored words list `codespell.txt` #11285

Fix spelling in Java and Python files; update the ignored words list `codespell.txt` #11285

codecov bot commented Jul 24, 2025 •

edited

Loading