server: trim autoscale Windows VM hostname #11327

shwstppr · 2025-07-29T10:16:01Z

Description

Fixes #9505

Trim the generated hostname for Windows VM to 15 characters.
Doc PR: apache/cloudstack-documentation#575

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Fixes apache#9505 Signed-off-by: Abhishek Kumar <[email protected]>

codecov · 2025-07-29T10:23:54Z

Codecov Report

❌ Patch coverage is 78.78788% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.54%. Comparing base (d60f455) to head (d24ffc3).
⚠️ Report is 30 commits behind head on main.

Files with missing lines	Patch %	Lines
...ava/com/cloud/network/as/AutoScaleManagerImpl.java	78.78%	3 Missing and 4 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #11327      +/-   ##
============================================
+ Coverage     17.50%   17.54%   +0.03%     
- Complexity    15427    15476      +49     
============================================
  Files          5894     5897       +3     
  Lines        526847   527426     +579     
  Branches      64335    64416      +81     
============================================
+ Hits          92234    92538     +304     
- Misses       424236   424489     +253     
- Partials      10377    10399      +22

Flag	Coverage Δ
uitests	`3.60% <ø> (-0.01%)`	⬇️
unittests	`18.60% <78.78%> (+0.04%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Abhishek Kumar <[email protected]>

shwstppr · 2025-07-30T06:22:40Z

@blueorangutan package

blueorangutan · 2025-07-30T06:24:04Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-07-30T08:56:52Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14463

github-actions · 2025-07-31T11:58:30Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

weizhouapache · 2025-08-25T10:47:55Z

@shwstppr
is this ready for review ?

shwstppr · 2025-08-25T11:02:10Z

@weizhouapache yes, though I wanted to confirm if it is a good idea to use the last 15 characters of the long generated name. Not using the first 15 as they can turn out to be the same.

weizhouapache · 2025-08-25T11:18:31Z

@weizhouapache yes, though I wanted to confirm if it is a good idea to use the last 15 characters of the long generated name. Not using the first 15 as they can turn out to be the same.

@shwstppr
looks ok to me. I could not find a better solution to be honest.

is it possible the first letter is unaccepted (for example -) after the truncation ?

Signed-off-by: Abhishek Kumar <[email protected]>

DaanHoogland · 2025-08-25T13:59:12Z

server/src/main/java/com/cloud/network/as/AutoScaleManagerImpl.java

+        if (Character.isLetterOrDigit(hostName.charAt(0))) {
+            return new Pair<>(hostName, name);
+        }
+        String temp = name.substring(0, Math.max(0, name.length() - 15)).replaceAll("[^a-zA-Z0-9]", "");


edge case: all of the last 15 chars are special chars or whitespace. I think we better do a replace first and then take the last 15.

@DaanHoogland I don't think this case can happen.
The only user-defined part in the VM name is the name of the autoscale group, and we've checks for that to only contain letters, numbers and hyphen. checkAutoScaleVmGroupName` does that

Signed-off-by: Abhishek Kumar <[email protected]>

shwstppr · 2025-08-26T04:52:44Z

@blueorangutan package

blueorangutan · 2025-08-26T04:54:04Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-08-26T06:53:43Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14730

server/src/main/java/com/cloud/network/as/AutoScaleManagerImpl.java

Signed-off-by: Abhishek Kumar <[email protected]>

shwstppr · 2025-09-10T04:10:55Z

@blueorangutan package

blueorangutan · 2025-09-10T04:12:03Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Signed-off-by: Abhishek Kumar <[email protected]>

shwstppr · 2025-09-30T13:26:32Z

@blueorangutan package

blueorangutan · 2025-09-30T13:28:06Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-09-30T14:41:25Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 15239

shwstppr · 2025-09-30T15:16:11Z

@abh1sar please try one again with new packages. Added a change. I didn't realize we store guest OSes with null name.

weizhouapache · 2025-09-30T15:24:23Z

@blueorangutan test

blueorangutan · 2025-09-30T15:26:04Z

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

abh1sar

Tested on Windows and Linux VM. The Windows VM name is getting truncated correctly.

abh1sar · 2025-10-01T04:09:50Z

@shwstppr please see if we need to add this to documentation?

Signed-off-by: Abhishek Kumar <[email protected]>

shwstppr · 2025-10-01T07:09:14Z

Thanks @abh1sar. (I've also added minor refactoring to not consider OS as Windows if both name and display_name turn out to be NULL)
Will check and update regarding documentation

Related apache/cloudstack#11327 Signed-off-by: Abhishek Kumar <[email protected]>

shwstppr · 2025-10-01T07:21:41Z

Added doc PR: apache/cloudstack-documentation#575

@blueorangutan package

blueorangutan · 2025-10-01T07:24:04Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-10-01T08:49:04Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15248

blueorangutan · 2025-10-01T08:56:07Z

[SF] Trillian test result (tid-14488)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 59706 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11327-t14488-kvm-ol8.zip
Smoke tests completed. 147 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

vishesh92

left some comments.

server/src/main/java/com/cloud/network/as/AutoScaleManagerImpl.java

Signed-off-by: Abhishek Kumar <[email protected]>

shwstppr · 2025-10-08T09:52:07Z

@blueorangutan package

blueorangutan · 2025-10-08T09:54:04Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-10-08T11:47:44Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15341

weizhouapache · 2025-10-08T12:18:48Z

Tested on Windows and Linux VM. The Windows VM name is getting truncated correctly.

to be frank, I think the name is a bit confusing

can we use a formatted shortname like asgroup-xxxxxx or asg-xx-xxxxxx instead ?

DaanHoogland · 2025-10-08T12:50:04Z

@weizhouapache @shwstppr is this not ready yet?

shwstppr · 2025-10-08T14:19:26Z

@DaanHoogland based on the latest comments I think we would need changes in naming implementation. I would close this for now for a different solution

server: trim autoscale Windows VM hostname

36e636a

Fixes apache#9505 Signed-off-by: Abhishek Kumar <[email protected]>

boring-cyborg bot added the component:networking label Jul 29, 2025

shwstppr added 2 commits July 30, 2025 11:11

fix

0c34a76

Signed-off-by: Abhishek Kumar <[email protected]>

fix imports

aa21706

Signed-off-by: Abhishek Kumar <[email protected]>

github-actions bot added the status:has-conflicts label Jul 31, 2025

Merge remote-tracking branch 'apache/main' into fix-autoscalewinvm

b97ef66

github-actions bot removed the status:has-conflicts label Aug 1, 2025

Merge branch 'main' into fix-autoscalewinvm

4c9de62

shwstppr marked this pull request as ready for review August 25, 2025 11:02

improve

4c9ff4c

Signed-off-by: Abhishek Kumar <[email protected]>

DaanHoogland reviewed Aug 25, 2025

View reviewed changes

return if okay

16240b9

Signed-off-by: Abhishek Kumar <[email protected]>

weizhouapache reviewed Aug 26, 2025

View reviewed changes

server/src/main/java/com/cloud/network/as/AutoScaleManagerImpl.java Outdated Show resolved Hide resolved

harikrishna-patnala added this to the 4.22.0 milestone Sep 3, 2025

harikrishna-patnala added this to Apache CloudStack 4.22.0 Sep 3, 2025

harikrishna-patnala moved this to In Progress in Apache CloudStack 4.22.0 Sep 3, 2025

address comment

1857433

Signed-off-by: Abhishek Kumar <[email protected]>

apache deleted a comment from blueorangutan Sep 30, 2025

missing test change

fa30c81

Signed-off-by: Abhishek Kumar <[email protected]>

abh1sar approved these changes Oct 1, 2025

View reviewed changes

shwstppr added 2 commits October 1, 2025 12:27

Merge remote-tracking branch 'apache/main' into fix-autoscalewinvm

1efc967

avoid chances of npe if both guestos name and displayname are null

313e4d4

Signed-off-by: Abhishek Kumar <[email protected]>

shwstppr added a commit to shapeblue/cloudstack-documentation that referenced this pull request Oct 1, 2025

note: trim on hostname for autoscale instances

5d09b59

Related apache/cloudstack#11327 Signed-off-by: Abhishek Kumar <[email protected]>

shwstppr mentioned this pull request Oct 1, 2025

note: trim on hostname for autoscale instances apache/cloudstack-documentation#575

Closed

vishesh92 reviewed Oct 1, 2025

View reviewed changes

server/src/main/java/com/cloud/network/as/AutoScaleManagerImpl.java Show resolved Hide resolved

server/src/main/java/com/cloud/network/as/AutoScaleManagerImpl.java Outdated Show resolved Hide resolved

change

d24ffc3

Signed-off-by: Abhishek Kumar <[email protected]>

vishesh92 approved these changes Oct 8, 2025

View reviewed changes

shwstppr closed this Oct 8, 2025

github-project-automation bot moved this from In Progress to Done in Apache CloudStack 4.22.0 Oct 8, 2025

server: trim autoscale Windows VM hostname #11327

server: trim autoscale Windows VM hostname #11327

Uh oh!

Conversation

shwstppr commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov bot commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

shwstppr commented Jul 30, 2025

Uh oh!

blueorangutan commented Jul 30, 2025

Uh oh!

blueorangutan commented Jul 30, 2025

Uh oh!

github-actions bot commented Jul 31, 2025

Uh oh!

weizhouapache commented Aug 25, 2025

Uh oh!

shwstppr commented Aug 25, 2025

Uh oh!

weizhouapache commented Aug 25, 2025

Uh oh!

DaanHoogland Aug 25, 2025

Choose a reason for hiding this comment

Uh oh!

shwstppr Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

shwstppr commented Aug 26, 2025

Uh oh!

blueorangutan commented Aug 26, 2025

Uh oh!

blueorangutan commented Aug 26, 2025

Uh oh!

Uh oh!

shwstppr commented Sep 10, 2025

Uh oh!

blueorangutan commented Sep 10, 2025

Uh oh!

shwstppr commented Sep 30, 2025

Uh oh!

blueorangutan commented Sep 30, 2025

Uh oh!

blueorangutan commented Sep 30, 2025

Uh oh!

shwstppr commented Sep 30, 2025

Uh oh!

weizhouapache commented Sep 30, 2025

Uh oh!

blueorangutan commented Sep 30, 2025

Uh oh!

abh1sar left a comment

Choose a reason for hiding this comment

Uh oh!

abh1sar commented Oct 1, 2025

Uh oh!

shwstppr commented Oct 1, 2025

Uh oh!

shwstppr commented Oct 1, 2025

Uh oh!

blueorangutan commented Oct 1, 2025

Uh oh!

blueorangutan commented Oct 1, 2025

Uh oh!

blueorangutan commented Oct 1, 2025

Uh oh!

vishesh92 left a comment

Choose a reason for hiding this comment

Uh oh!

shwstppr commented Jul 29, 2025 •

edited

Loading

codecov bot commented Jul 29, 2025 •

edited

Loading