server: run the vm scheduler poll task on only one management server #11573

weizhouapache · 2025-09-04T06:48:45Z

Description

This PR fixes #11564

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov · 2025-09-04T06:56:48Z

Codecov Report

❌ Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.17%. Comparing base (db5b6a5) to head (4cd164d).
⚠️ Report is 27 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
...cloud/cluster/dao/ManagementServerHostDaoImpl.java	0.00%	11 Missing ⚠️
...apache/cloudstack/vm/schedule/VMSchedulerImpl.java	0.00%	4 Missing ⚠️
...che/cloudstack/mom/webhook/WebhookServiceImpl.java	0.00%	1 Missing ⚠️
.../cloud/resourcelimit/ResourceLimitManagerImpl.java	0.00%	1 Missing ⚠️
...loudstack/resource/ResourceCleanupServiceImpl.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##               4.20   #11573    +/-   ##
==========================================
  Coverage     16.17%   16.17%            
- Complexity    13286    13299    +13     
==========================================
  Files          5656     5656            
  Lines        498015   498162   +147     
  Branches      60406    60443    +37     
==========================================
+ Hits          80538    80589    +51     
- Misses       408515   408602    +87     
- Partials       8962     8971     +9

Flag	Coverage Δ
uitests	`4.00% <ø> (-0.01%)`	⬇️
unittests	`17.03% <0.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

shwstppr

looks good. One comment

server/src/main/java/org/apache/cloudstack/vm/schedule/VMSchedulerImpl.java

shwstppr · 2025-09-04T07:49:50Z

@blueorangutan package

blueorangutan · 2025-09-04T07:52:03Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-09-04T09:31:48Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14843

weizhouapache · 2025-09-04T12:00:40Z

@blueorangutan package

blueorangutan · 2025-09-04T12:02:07Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-09-04T13:32:35Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14849

server/src/main/java/org/apache/cloudstack/vm/schedule/VMSchedulerImpl.java

shwstppr · 2025-09-07T05:18:13Z

@blueorangutan test

blueorangutan · 2025-09-07T05:20:04Z

@shwstppr a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-09-07T20:44:07Z

[SF] Trillian test result (tid-14233)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 52446 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11573-t14233-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

server/src/main/java/org/apache/cloudstack/vm/schedule/VMSchedulerImpl.java

DaanHoogland

clgtm

weizhouapache · 2025-09-10T06:40:58Z

@vishesh92
I added a new method to get mgmt server based on the class name, it could be used in other places too

vishesh92

code looks good to me

weizhouapache · 2025-09-12T06:50:04Z

@vishesh92
can you please test this PR when you have time ? thanks

vishesh92 · 2025-09-12T07:08:15Z

@blueorangutan package

blueorangutan · 2025-09-12T07:10:04Z

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-09-12T08:29:08Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14975

vishesh92 · 2025-09-15T06:01:38Z

@weizhouapache I created two schedules like below on a single VM and I am still seeing the DB Exception in the logs. The execution of the schedules is happening only one server now.

2025-09-15 06:00:35,388 ERROR [o.a.c.v.s.d.VMScheduledJobDaoImpl] (VMSchedulerPollTask:[ctx-1d917c1b]) (logid:44f16569) DB Exception on: HikariProxyPreparedStatement@135121997 wrapping com.mysql.cj.jdbc.ServerPreparedStatement[368]: INSERT INTO vm_scheduled_job (vm_scheduled_job.uuid, vm_scheduled_job.vm_id, vm_scheduled_job.vm_schedule_id, vm_scheduled_job.async_job_id, vm_scheduled_job.action, vm_scheduled_job.scheduled_timestamp) VALUES (x'30333531303530382d616433642d346362342d626632352d633463666538303538653063', 3, 1, NULL, 'START', '2025-09-15 06:02:00') java.sql.SQLIntegrityConstraintViolationException: Duplicate entry '1-2025-09-15 06:02:00' for key 'vm_scheduled_job.vm_schedule_id'
        at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:118)
        at com.mysql.cj.jdbc.exceptions.SQLExceptionsMapping.translateException(SQLExceptionsMapping.java:122)
        at com.mysql.cj.jdbc.ServerPreparedStatement.serverExecute(ServerPreparedStatement.java:555)
        at com.mysql.cj.jdbc.ServerPreparedStatement.executeInternal(ServerPreparedStatement.java:339)
        at com.mysql.cj.jdbc.ClientPreparedStatement.executeUpdateInternal(ClientPreparedStatement.java:1061)
        at com.mysql.cj.jdbc.ClientPreparedStatement.executeUpdateInternal(ClientPreparedStatement.java:1009)
        at com.mysql.cj.jdbc.ClientPreparedStatement.executeLargeUpdate(ClientPreparedStatement.java:1320)
        at com.mysql.cj.jdbc.ClientPreparedStatement.executeUpdate(ClientPreparedStatement.java:994)
        at com.zaxxer.hikari.pool.ProxyPreparedStatement.executeUpdate(ProxyPreparedStatement.java:61)
        at com.zaxxer.hikari.pool.HikariProxyPreparedStatement.executeUpdate(HikariProxyPreparedStatement.java)
        at com.cloud.utils.db.GenericDaoBase.persist(GenericDaoBase.java:1625)
        at jdk.internal.reflect.GeneratedMethodAccessor12.invoke(Unknown Source)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:569)
        at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:344)
        at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:198)
        at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
        at com.cloud.utils.db.TransactionContextInterceptor.invoke(TransactionContextInterceptor.java:34)
        at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:175)
        at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:97)
        at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
        at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:215)
        at jdk.proxy3/jdk.proxy3.$Proxy374.persist(Unknown Source)
        at org.apache.cloudstack.vm.schedule.VMSchedulerImpl.scheduleNextJob(VMSchedulerImpl.java:173)
        at org.apache.cloudstack.vm.schedule.VMSchedulerImpl.scheduleNextJobs(VMSchedulerImpl.java:259)
        at org.apache.cloudstack.vm.schedule.VMSchedulerImpl.poll(VMSchedulerImpl.java:227)
        at org.apache.cloudstack.vm.schedule.VMSchedulerImpl$1.runInContext(VMSchedulerImpl.java:205)
        at org.apache.cloudstack.managed.context.ManagedContextTimerTask$1.runInContext(ManagedContextTimerTask.java:30)
        at org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
        at org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
        at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
        at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
        at org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)
        at org.apache.cloudstack.managed.context.ManagedContextTimerTask.run(ManagedContextTimerTask.java:32)
        at java.base/java.util.TimerThread.mainLoop(Timer.java:566)
        at java.base/java.util.TimerThread.run(Timer.java:516)

weizhouapache · 2025-09-15T06:24:43Z

thanks @vishesh92 for testing

as discussed offline, it is a minor issue.
it seems to be because the the job is scheduled twice by the same management server . so this PR is incorrect

server: run the vm scheduler poll task on only one management server

7ecfb41

weizhouapache added this to the 4.20.2 milestone Sep 4, 2025

weizhouapache linked an issue Sep 4, 2025 that may be closed by this pull request

Recurrent insert errors in database on vm schedules #11564

Open

shwstppr approved these changes Sep 4, 2025

View reviewed changes

server/src/main/java/org/apache/cloudstack/vm/schedule/VMSchedulerImpl.java Outdated Show resolved Hide resolved

Update 11573

f1e91c4

Update method to findOneInUpStateByLongestRuntime

06b0504

rohityadavcloud reviewed Sep 5, 2025

View reviewed changes

server/src/main/java/org/apache/cloudstack/vm/schedule/VMSchedulerImpl.java Outdated Show resolved Hide resolved

DaanHoogland reviewed Sep 8, 2025

View reviewed changes

server/src/main/java/org/apache/cloudstack/vm/schedule/VMSchedulerImpl.java Show resolved Hide resolved

DaanHoogland approved these changes Sep 9, 2025

View reviewed changes

DaanHoogland added the status:needs-testing label Sep 9, 2025

add method findOneInUpState to get mgmt server from class name

e1ddb41

weizhouapache force-pushed the 4.20-fix-11564 branch from b0a6edb to e1ddb41 Compare September 10, 2025 06:44

vishesh92 approved these changes Sep 10, 2025

View reviewed changes

weizhouapache closed this Sep 15, 2025

Update 11573: order mgmt servers by id

4cd164d

weizhouapache reopened this Sep 15, 2025

weizhouapache closed this Sep 15, 2025

server: run the vm scheduler poll task on only one management server #11573

server: run the vm scheduler poll task on only one management server #11573

Uh oh!

Conversation

weizhouapache commented Sep 4, 2025

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov bot commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

shwstppr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

shwstppr commented Sep 4, 2025

Uh oh!

blueorangutan commented Sep 4, 2025

Uh oh!

blueorangutan commented Sep 4, 2025

Uh oh!

weizhouapache commented Sep 4, 2025

Uh oh!

blueorangutan commented Sep 4, 2025

Uh oh!

blueorangutan commented Sep 4, 2025

Uh oh!

Uh oh!

shwstppr commented Sep 7, 2025

Uh oh!

blueorangutan commented Sep 7, 2025

Uh oh!

blueorangutan commented Sep 7, 2025

Uh oh!

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

weizhouapache commented Sep 10, 2025

Uh oh!

vishesh92 left a comment

Choose a reason for hiding this comment

Uh oh!

weizhouapache commented Sep 12, 2025

Uh oh!

vishesh92 commented Sep 12, 2025

Uh oh!

blueorangutan commented Sep 12, 2025

Uh oh!

blueorangutan commented Sep 12, 2025

Uh oh!

vishesh92 commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

weizhouapache commented Sep 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Sep 4, 2025 •

edited

Loading

vishesh92 commented Sep 15, 2025 •

edited

Loading