api,server,ui: improve listing public ip for associate #11591

shwstppr · 2025-09-06T08:06:18Z

Description

Currently, acquire or associate IP action in the UI will load only 500 addresses (or whatever defined by config default.page.size). Also, it will load all 500 of them together. This PR uses InfiniteScrollSelect to iteratively load more addresses. To facilitate retrieving both Free and Reserved addresses api and server change has been made for the listPublicIpAddresses API to pass a comma-separated list of states for state parameter.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov · 2025-09-06T08:14:39Z

Codecov Report

❌ Patch coverage is 66.66667% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.55%. Comparing base (f67b738) to head (42e8a73).
⚠️ Report is 18 commits behind head on main.

Files with missing lines	Patch %	Lines
...in/java/com/cloud/server/ManagementServerImpl.java	66.66%	7 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##               main   #11591     +/-   ##
===========================================
  Coverage     17.54%   17.55%             
- Complexity    15483    15523     +40     
===========================================
  Files          5897     5907     +10     
  Lines        527484   528631   +1147     
  Branches      64432    64550    +118     
===========================================
+ Hits          92566    92801    +235     
- Misses       424508   425397    +889     
- Partials      10410    10433     +23

Flag	Coverage Δ
uitests	`3.59% <ø> (-0.02%)`	⬇️
unittests	`18.62% <66.66%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

shwstppr · 2025-09-06T08:22:33Z

@blueorangutan package

blueorangutan · 2025-09-06T08:24:03Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-09-06T10:05:31Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14878

DaanHoogland · 2025-09-08T14:10:19Z

@blueorangutan test keepEnv

blueorangutan · 2025-09-08T14:12:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

server/src/main/java/com/cloud/server/ManagementServerImpl.java

Copilot

Pull Request Overview

This pull request enhances the public IP address listing functionality in CloudStack by enabling iterative loading through infinite scroll and supporting multiple states. The primary improvement is in the UI's IP acquisition/association interface, which previously loaded only 500 addresses synchronously.

Key changes include:

Modified listPublicIpAddresses API to accept comma-separated states parameter
Replaced static select component with infinite scroll select in UI
Updated server-side filtering to handle multiple states
Enhanced test coverage for new multi-state functionality

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
ui/src/views/network/IpAddressesTab.vue	Replaces static select with InfiniteScrollSelect component and removes manual IP loading logic
ui/src/components/widgets/InfiniteScrollSelect.vue	Adds support for custom label functions and auto-selection of first option
server/src/main/java/com/cloud/server/ManagementServerImpl.java	Implements comma-separated state parameter parsing and multi-state filtering
api/src/main/java/org/apache/cloudstack/api/command/user/address/ListPublicIpAddressesCmd.java	Updates API documentation to reflect comma-separated state support
server/src/test/java/com/cloud/server/ManagementServerImplTest.java	Updates test methods to accommodate new multi-state parameter structure

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

ui/src/components/widgets/InfiniteScrollSelect.vue

harikrishna-patnala

code LGTM

harikrishna-patnala · 2025-09-11T05:18:58Z

@blueorangutan package

blueorangutan · 2025-09-11T05:20:03Z

@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-09-11T06:32:26Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14949

DaanHoogland

code looks good, just one remark, no blocker

DaanHoogland · 2025-09-15T09:35:03Z

server/src/main/java/com/cloud/server/ManagementServerImpl.java

+        List<IpAddress.State> states = new ArrayList<>();
+        if (StringUtils.isNotBlank(state)) {
+            for (String s : StringUtils.split(state, ",")) {
+                try {
+                    states.add(IpAddress.State.valueOf(s));
+                } catch (IllegalArgumentException e) {
+                    throw new InvalidParameterValueException("Invalid state: " + s);
+                }
+            }
+        }
        Boolean isAllocated = cmd.isAllocatedOnly();
        if (isAllocated == null) {
-            if (state != null && (state.equalsIgnoreCase(IpAddress.State.Free.name()) || state.equalsIgnoreCase(IpAddress.State.Reserved.name()))) {
+            if (states.contains(IpAddress.State.Free) || states.contains(IpAddress.State.Reserved)) {
                isAllocated = Boolean.FALSE;
            } else {
                isAllocated = Boolean.TRUE; // default
            }
        } else {
-            if (state != null && (state.equalsIgnoreCase(IpAddress.State.Free.name()) || state.equalsIgnoreCase(IpAddress.State.Reserved.name()))) {
+            if (states.contains(IpAddress.State.Free) || states.contains(IpAddress.State.Reserved)) {
                if (isAllocated) {
                    throw new InvalidParameterValueException("Conflict: allocatedonly is true but state is Free");
                }
-            } else if (state != null && state.equalsIgnoreCase(IpAddress.State.Allocated.name())) {
+            } else if (states.contains(IpAddress.State.Allocated)) {
                isAllocated = Boolean.TRUE;
            }
        }


can we move this logic to its own method?

github-actions · 2025-10-07T17:17:50Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

shwstppr · 2025-10-07T18:33:26Z

@blueorangutan package

blueorangutan · 2025-10-07T18:34:04Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-10-07T19:50:58Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15327

harikrishna-patnala · 2025-10-08T07:53:17Z

ui/src/views/network/IpAddressesTab.vue

+    },
+    listApiParamsForAssociate () {
+      const params = this.listApiParams
+      params.state = 'Free,Reserved'


@shwstppr I tested the changes, it is not listing any IPs now

Seems to be problem with these params

http://10.0.32.194:8080/client/api/?page=1&pagesize=20&zoneid=eb21bc9a-4c08-4456-938b-af605ef36aae&domainid=d3a3e350-a40d-11f0-b82c-1e009c000155&account=admin&forvirtualnetwork=true&allocatedonly=false& state=Free,Reserved &showicon=true&command=listPublicIpAddresses&response=json&sessionkey=fSa-6YW14skm_KeFEJvTnLPpQQs

Thanks for checking @harikrishna-patnala. Will check and fix. Moving to draft for now

@harikrishna-patnala changes should work now

Currently, acquire or associate IP action in the UI will load only 500 addresses. ALso, it will load all 500 of them together. This PR uses InfiniteScrollSelect to iteratively load more addresses. To facilitate retrieving both Free and Reserved addresses api and server change has been made for the listPublicIpAddresses API to pass a comma-separated list of states for state parameter. Signed-off-by: Abhishek Kumar <[email protected]>

shwstppr · 2025-10-09T14:11:17Z

@blueorangutan package

blueorangutan · 2025-10-09T14:12:04Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-10-09T16:00:48Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 15370

Signed-off-by: Abhishek Kumar <[email protected]>

shwstppr · 2025-10-10T04:35:14Z

@blueorangutan package

blueorangutan · 2025-10-10T04:36:04Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-10-10T06:45:02Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 15387

server/src/main/java/com/cloud/server/ManagementServerImpl.java

Signed-off-by: Abhishek Kumar <[email protected]>

shwstppr · 2025-10-12T06:09:06Z

@blueorangutan package

blueorangutan · 2025-10-12T06:10:04Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-10-12T07:27:27Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15420

vishesh92 · 2025-10-13T07:51:26Z

utils/src/main/java/com/cloud/utils/EnumUtils.java

        return null;
    }
+
+    public static <T extends Enum<T>> T getEnumIgnoreCase(Class<T> enumClass, String name) {


We can use org.apache.commons.lang3.EnumUtils's getEnumIgnoreCase instead of this which does the exact the same thing.

so let’s make this class a child of the commons one (keeping the enum related utils in one place.

Done @vishesh92

shwstppr · 2025-10-13T10:42:49Z

~~Will work later~~
Updated code to use commons' class

Signed-off-by: Abhishek Kumar <[email protected]>

shwstppr · 2025-10-13T11:12:07Z

@blueorangutan package

blueorangutan · 2025-10-13T11:14:04Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

vishesh92

clgtm. didn't test.

blueorangutan · 2025-10-13T13:09:26Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 15436

boring-cyborg bot added component:api component:management-server component:UI labels Sep 6, 2025

harikrishna-patnala added this to the 4.22.0 milestone Sep 8, 2025

harikrishna-patnala added this to Apache CloudStack 4.22.0 Sep 8, 2025

harikrishna-patnala moved this to In Progress in Apache CloudStack 4.22.0 Sep 8, 2025

harikrishna-patnala reviewed Sep 10, 2025

View reviewed changes

server/src/main/java/com/cloud/server/ManagementServerImpl.java Outdated Show resolved Hide resolved

shwstppr requested a review from Copilot September 10, 2025 09:10

Copilot AI reviewed Sep 10, 2025

View reviewed changes

ui/src/components/widgets/InfiniteScrollSelect.vue Show resolved Hide resolved

ui/src/components/widgets/InfiniteScrollSelect.vue Show resolved Hide resolved

harikrishna-patnala approved these changes Sep 11, 2025

View reviewed changes

DaanHoogland approved these changes Sep 15, 2025

View reviewed changes

github-actions bot added the status:has-conflicts label Oct 7, 2025

github-actions bot removed the status:has-conflicts label Oct 7, 2025

harikrishna-patnala self-requested a review October 8, 2025 07:48

harikrishna-patnala reviewed Oct 8, 2025

View reviewed changes

harikrishna-patnala self-requested a review October 8, 2025 07:54

shwstppr marked this pull request as draft October 9, 2025 12:22

shwstppr force-pushed the improve-publicip-associate branch from f7999bc to 8e414a6 Compare October 9, 2025 14:10

refactor

0e2fec1

Signed-off-by: Abhishek Kumar <[email protected]>

shwstppr marked this pull request as ready for review October 10, 2025 07:49

vishesh92 reviewed Oct 10, 2025

View reviewed changes

server/src/main/java/com/cloud/server/ManagementServerImpl.java Outdated Show resolved Hide resolved

vishesh92 self-assigned this Oct 10, 2025

change

cb1c0aa

Signed-off-by: Abhishek Kumar <[email protected]>

vishesh92 reviewed Oct 13, 2025

View reviewed changes

shwstppr closed this Oct 13, 2025

github-project-automation bot moved this from In Progress to Done in Apache CloudStack 4.22.0 Oct 13, 2025

user commons

42e8a73

Signed-off-by: Abhishek Kumar <[email protected]>

shwstppr reopened this Oct 13, 2025

vishesh92 approved these changes Oct 13, 2025

View reviewed changes

api,server,ui: improve listing public ip for associate #11591

Are you sure you want to change the base?

api,server,ui: improve listing public ip for associate #11591

Conversation

shwstppr commented Sep 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov bot commented Sep 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

shwstppr commented Sep 6, 2025

Uh oh!

blueorangutan commented Sep 6, 2025

Uh oh!

blueorangutan commented Sep 6, 2025

Uh oh!

DaanHoogland commented Sep 8, 2025

Uh oh!

blueorangutan commented Sep 8, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

harikrishna-patnala left a comment

Choose a reason for hiding this comment

Uh oh!

harikrishna-patnala commented Sep 11, 2025

Uh oh!

blueorangutan commented Sep 11, 2025

Uh oh!

blueorangutan commented Sep 11, 2025

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland Sep 15, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 7, 2025

Uh oh!

shwstppr commented Oct 7, 2025

Uh oh!

blueorangutan commented Oct 7, 2025

Uh oh!

blueorangutan commented Oct 7, 2025

Uh oh!

harikrishna-patnala Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shwstppr Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

shwstppr Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

shwstppr commented Oct 9, 2025

Uh oh!

blueorangutan commented Oct 9, 2025

Uh oh!

blueorangutan commented Oct 9, 2025

Uh oh!

shwstppr commented Oct 10, 2025

Uh oh!

blueorangutan commented Oct 10, 2025

Uh oh!

shwstppr commented Sep 6, 2025 •

edited

Loading

codecov bot commented Sep 6, 2025 •

edited

Loading

harikrishna-patnala Oct 8, 2025 •

edited

Loading

shwstppr commented Oct 13, 2025 •

edited

Loading