Skip to content

Conversation

shwstppr
Copy link
Contributor

@shwstppr shwstppr commented Sep 26, 2025

Description

Fixes #11643
Disable reset configuration action when the current value for the config is its default value

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

reset-cfg-disabled.mp4

Copy link

codecov bot commented Sep 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 3.61%. Comparing base (8089d32) to head (bbba7d7).
⚠️ Report is 54 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (8089d32) and HEAD (bbba7d7). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (8089d32) HEAD (bbba7d7)
unittests 1 0
Additional details and impacted files
@@              Coverage Diff              @@
##               main   #11728       +/-   ##
=============================================
- Coverage     17.36%    3.61%   -13.75%     
=============================================
  Files          5888      442     -5446     
  Lines        525831    37273   -488558     
  Branches      64183     6842    -57341     
=============================================
- Hits          91298     1347    -89951     
+ Misses       424227    35762   -388465     
+ Partials      10306      164    -10142     
Flag Coverage Δ
uitests 3.61% <ø> (-0.02%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shwstppr
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11728 (QA-JID-766)

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@shwstppr shwstppr marked this pull request as ready for review September 27, 2025 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

indicate a setting has a default value (and what it is)
3 participants