Skip to content

Conversation

sudo87
Copy link
Collaborator

@sudo87 sudo87 commented Sep 30, 2025

Description

This PR fixes #8567

  1. Primary storage creation for data store cluster in zone deployment
  2. Retaining label for traffic type

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

  1. By deploying Zone with data store cluster for Vmware
  2. Validated traffic label for kvm deployment

How did you try to break this feature and the system with this change?

@sudo87
Copy link
Collaborator Author

sudo87 commented Sep 30, 2025

@blueorangutan uibuild

@blueorangutan
Copy link

@sudo87 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

Copy link

codecov bot commented Sep 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 16.17%. Comparing base (5dfeb79) to head (9fd28b5).
⚠️ Report is 8 commits behind head on 4.20.

Additional details and impacted files
@@             Coverage Diff              @@
##               4.20   #11760      +/-   ##
============================================
- Coverage     16.17%   16.17%   -0.01%     
+ Complexity    13296    13295       -1     
============================================
  Files          5656     5656              
  Lines        498223   498263      +40     
  Branches      60454    60465      +11     
============================================
+ Hits          80577    80582       +5     
- Misses       408676   408711      +35     
  Partials       8970     8970              
Flag Coverage Δ
uitests 4.00% <ø> (-0.01%) ⬇️
unittests 17.02% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11760 (QA-JID-767)

Copy link
Contributor

@harikrishna-patnala harikrishna-patnala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@sudo87 sudo87 changed the title UI: retain traffic labels during zone deployment UI: Fix primary storage for datastore cluster and retain traffic labels during zone deployment Oct 1, 2025
@sudo87
Copy link
Collaborator Author

sudo87 commented Oct 1, 2025

@blueorangutan uibuild

@blueorangutan
Copy link

@sudo87 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11760 (QA-JID-771)

Copy link
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sudo87 - LGTM

@harikrishna-patnala harikrishna-patnala added this to the 4.20.2 milestone Oct 2, 2025
@sudo87
Copy link
Collaborator Author

sudo87 commented Oct 3, 2025

@blueorangutan package

@blueorangutan
Copy link

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15270

@sudo87
Copy link
Collaborator Author

sudo87 commented Oct 7, 2025

@blueorangutan test

@blueorangutan
Copy link

@sudo87 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@vishesh92
Copy link
Member

@blueorangutan ui

@blueorangutan
Copy link

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11760 (QA-JID-774)

Copy link
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. tested and verified the fix for the traffic labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants