agent: increase timeout for host arch retrieval #11822
Conversation
Cherry-picked from 44f8064 Signed-off-by: Abhishek Kumar <[email protected]>
rohityadavcloud
requested review from
DaanHoogland,
shwstppr and
weizhouapache
|
@blueorangutan package |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #11822 +/- ##
============================================
- Coverage 16.17% 16.17% -0.01%
- Complexity 13297 13298 +1
============================================
Files 5656 5656
Lines 498331 498331
Branches 60476 60476
============================================
- Hits 80591 80590 -1
- Misses 408767 408769 +2
+ Partials 8973 8972 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| final Script command = new Script("/usr/bin/arch", 500, logger); | ||
| final OutputInterpreter.OneLineParser parser = new OutputInterpreter.OneLineParser(); | ||
| return command.execute(parser); | ||
| String arch = Script.runSimpleBashScript(Script.getExecutableAbsolutePath("arch"), 2000); |
There was a problem hiding this comment.
original PR had timeout as 1000 (base on my tests with OL8 x86_64 #11251 (comment)), this has 2000. Is there a new finding? Would it make sense to make this configurable then?
There was a problem hiding this comment.
@rohityadavcloud
would it be better same as #11254 ?
There was a problem hiding this comment.
I've explained my thinking but feel free to revert otherwise @weizhouapache @shwstppr
|
can you test the changes ? thanks |
|
@shwstppr |
If that is something we've agreed then fine with me |
|
The increased timeout just increases the chance without failure, that being max. timeout shouldn't affect other systems where the command returns quickly. @weizhouapache @shwstppr I had increased it as usually timeouts can be larger than it would rather take for a command. |
thanks @rohityadavcloud @shwstppr for your comments. |
…e#11822) Cherry-picked from 44f8064 Signed-off-by: Abhishek Kumar <[email protected]> Co-authored-by: Abhishek Kumar <[email protected]>
5 participants
Backport 44f8064 from #11254
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?