-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Public to external #11891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Public to external #11891
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR systematically updates UI localization strings to replace terminology of "public" IP addresses and related infrastructure with "external" IP addresses. The change affects user-facing labels and messages throughout the application to use more precise terminology that better reflects the nature of externally-routable IP addresses.
Key Changes:
- Renamed all references from "public IP" to "external IP" in user interface strings
- Updated traffic-related terminology from "public traffic" to "external traffic"
- Modified configuration paths and instructions to reflect the new terminology
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ui/public/locales/en.json
Outdated
| "label.kubeconfig.cluster": "Kubernetes Cluster config", | ||
| "label.kubernetes": "Kubernetes", | ||
| "label.kubernetes.access.details": "The kubernetes nodes can be accessed via ssh using: <br> <code><b> ssh -i [ssh_key] -p [port_number] cloud@[public_ip_address] </b></code> <br><br> where, <br> <code><b>ssh_key:</b></code> points to the ssh private key file corresponding to the key that was associated while creating the Kubernetes Cluster. If no ssh key was provided during Kubernetes cluster creation, use the ssh private key of the management server. <br> <code><b>port_number:</b></code> can be obtained from the Port Forwarding Tab (Public Port column)", | ||
| "label.kubernetes.access.details": "The kubernetes nodes can be accessed via ssh using: <br> <code><b> ssh -i [ssh_key] -p [port_number] cloud@[external_ip_address] </b></code> <br><br> where, <br> <code><b>ssh_key:</b></code> points to the ssh private key file corresponding to the key that was associated while creating the Kubernetes Cluster. If no ssh key was provided during Kubernetes cluster creation, use the ssh private key of the management server. <br> <code><b>port_number:</b></code> can be obtained from the Port Forwarding Tab (External Port column)", |
Copilot
AI
Oct 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description text references 'External Port column' but the port forwarding tab likely still uses the original column name. This should be verified to ensure the documentation matches the actual UI column headers.
| "label.kubernetes.access.details": "The kubernetes nodes can be accessed via ssh using: <br> <code><b> ssh -i [ssh_key] -p [port_number] cloud@[external_ip_address] </b></code> <br><br> where, <br> <code><b>ssh_key:</b></code> points to the ssh private key file corresponding to the key that was associated while creating the Kubernetes Cluster. If no ssh key was provided during Kubernetes cluster creation, use the ssh private key of the management server. <br> <code><b>port_number:</b></code> can be obtained from the Port Forwarding Tab (External Port column)", | |
| "label.kubernetes.access.details": "The kubernetes nodes can be accessed via ssh using: <br> <code><b> ssh -i [ssh_key] -p [port_number] cloud@[external_ip_address] </b></code> <br><br> where, <br> <code><b>ssh_key:</b></code> points to the ssh private key file corresponding to the key that was associated while creating the Kubernetes Cluster. If no ssh key was provided during Kubernetes cluster creation, use the ssh private key of the management server. <br> <code><b>port_number:</b></code> can be obtained from the Port Forwarding Tab (Public Port column)", |
ui/public/locales/en.json
Outdated
| "label.set.reservation.desc": "You can make External IP range external, or you can dedicate/reserve it for either an Account or for System VMs", | ||
| "label.set.reservation.account.desc": "Please specify an Account to be associated with this IP range.", | ||
| "label.set.reservation.systemvm.desc": "Enable dedication of public IP range for SSVM and CPVM. Reservation strictness defined on 'system.vm.public.ip.reservation.mode.strictness'.", | ||
| "label.set.reservation.systemvm.desc": "Enable dedication of external IP range for SSVM and CPVM. Reservation strictness defined on 'system.vm.external.ip.reservation.mode.strictness'.", |
Copilot
AI
Oct 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The configuration key name 'system.vm.external.ip.reservation.mode.strictness' may not match the actual configuration key in the system, which likely still uses 'public' in its name. This reference should be verified against the actual configuration schema.
| "label.set.reservation.systemvm.desc": "Enable dedication of external IP range for SSVM and CPVM. Reservation strictness defined on 'system.vm.external.ip.reservation.mode.strictness'.", | |
| "label.set.reservation.systemvm.desc": "Enable dedication of external IP range for SSVM and CPVM. Reservation strictness defined on 'system.vm.public.ip.reservation.mode.strictness'.", |
ui/public/locales/en.json
Outdated
| "label.test.webhook.delivery": "Test Webhook Delivery", | ||
| "label.tftpdir": "TFTP root directory", | ||
| "label.theme.alert": "The setting is only visible to the current browser. To apply the setting, please download the JSON file and replace its content in the `theme` section of the `config.json` file under the path: `/public/config.json`", | ||
| "label.theme.alert": "The setting is only visible to the current browser. To apply the setting, please download the JSON file and replace its content in the `theme` section of the `config.json` file under the path: `/external/config.json`", |
Copilot
AI
Oct 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file path was incorrectly changed from /public/config.json to /external/config.json. The directory /public is a standard convention in web applications for publicly-accessible static assets and should not be renamed to /external as part of this IP address terminology change.
| "label.theme.alert": "The setting is only visible to the current browser. To apply the setting, please download the JSON file and replace its content in the `theme` section of the `config.json` file under the path: `/external/config.json`", | |
| "label.theme.alert": "The setting is only visible to the current browser. To apply the setting, please download the JSON file and replace its content in the `theme` section of the `config.json` file under the path: `/public/config.json`", |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11891 +/- ##
============================================
- Coverage 17.56% 17.56% -0.01%
+ Complexity 15532 15530 -2
============================================
Files 5909 5909
Lines 529012 529012
Branches 64604 64604
============================================
- Hits 92913 92904 -9
- Misses 425652 425661 +9
Partials 10447 10447
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Public to external