Fix: NPE thrown on VMware to KVM migration tasks listing for removed VMs

[nvazquez]

Description

This PR fixes an issue while listing migration tasks if some of the migrated VMs are removed after the migration, resulting on not being able to list the past migration tasks.

Completed migrations:

After removing one of the migrated VMs, the listing failed:

After the fix:

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

• Migrate VMware VM to KVM
• Remove VM
• List 'All' or 'Completed' tasks

How did you try to break this feature and the system with this change?

[nvazquez]

@blueorangutan package

[blueorangutan]

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[Pearl1594]

code lgtm.

[weizhouapache]

code lgtm

[codecov]

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.63%. Comparing base (8bbe253) to head (a5b1df8).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...apache/cloudstack/vm/ImportVmTasksManagerImpl.java	0.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #11892      +/-   ##
============================================
+ Coverage     17.56%   18.63%   +1.06%     
- Complexity    15532    15533       +1     
============================================
  Files          5909     5464     -445     
  Lines        529012   491481   -37531     
  Branches      64604    57704    -6900     
============================================
- Hits          92913    91567    -1346     
+ Misses       425652   389630   -36022     
+ Partials      10447    10284     -163     

Flag	Coverage Δ
uitests	?
unittests	18.63% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15524

[nvazquez]

@blueorangutan test

[blueorangutan]

@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-14711)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 17464 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11892-t14711-kvm-ol8.zip
Intermittent failure detected: /marvin/tests/smoke/test_direct_download.py