Skip to content

Conversation

@erikbocks
Copy link
Collaborator

Description

Currently, the icon displayed for Kubernetes in the GUI is a Buddhist dharmachakra. This PR fixes this by changing the icon displayed in the GUI to the official Kubernetes logo.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

The icon displayed before the changes:

Before image image

After the changes:

After image image

How Has This Been Tested?

After changing the icon, I ran the UI locally by using npm run serve, then validated that the new icon was displayed correctly in the Compute, Create and Images tabs.

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.56%. Comparing base (ec533cd) to head (d44b8f9).
⚠️ Report is 88 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11895      +/-   ##
============================================
+ Coverage     17.42%   17.56%   +0.13%     
- Complexity    15336    15532     +196     
============================================
  Files          5892     5909      +17     
  Lines        526521   529014    +2493     
  Branches      64293    64604     +311     
============================================
+ Hits          91767    92915    +1148     
- Misses       424401   425652    +1251     
- Partials      10353    10447      +94     
Flag Coverage Δ
uitests 3.58% <ø> (-0.03%) ⬇️
unittests 18.63% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@@ -26,7 +26,7 @@
<a-avatar :style="{ backgroundColor: $config.theme['@primary-color'] }">
<template #icon>
<render-icon v-if="(typeof menuItem.icon === 'string')" :icon="menuItem.icon" />
<font-awesome-icon v-else :icon="menuItem.icon" />
<render-icon v-else :style="{fill:'#ffffff'}" :svg-icon=menuItem.icon />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the fill-style needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants