-
Notifications
You must be signed in to change notification settings - Fork 1.2k
UI: Minor fix for extra params display for VMware to KVM migration #11909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Minor fix for extra params display for VMware to KVM migration #11909
Conversation
|
@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11909 +/- ##
=========================================
Coverage 17.55% 17.56%
+ Complexity 15531 15530 -1
=========================================
Files 5909 5909
Lines 529008 529008
Branches 64605 64605
=========================================
+ Hits 92893 92905 +12
+ Misses 425669 425656 -13
- Partials 10446 10447 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
UI build: ✔️ |
harikrishna-patnala
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM
|
@blueorangutan package |
|
@rosi-shapeblue a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15559 |
sureshanaparti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
Description
This PR addresses a small UI issue on the VMware to KVM migration dialog to hide/display the extra parameters according to the global setting
convert.vmware.instance.to.kvm.extra.params.allowedvalueScreen.Recording.2025-10-24.at.2.21.43.PM.mov
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?