Use correct offset when previous entry is a directory.#509
Open
krite wants to merge 1 commit intoapache:masterfrom
Open
Use correct offset when previous entry is a directory.#509krite wants to merge 1 commit intoapache:masterfrom
krite wants to merge 1 commit intoapache:masterfrom
Conversation
Member
|
Hello @krite |
Member
|
@krite |
Member
|
Hello @krite |
Member
|
@krite |
Contributor
|
The author is probably no longer active, but I can build on top of this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current implementation cannot read tar-files with folders.
This can easily be tested either by using commons-compress or any other valid tar-tool.
Create a simple folder-structure containing two folders, with a single file in each, create a uncompressed tar-file.
Reading back the file will cause a "Corrupted TAR archive" from TarArchiveEntry:1464, since the incorrect data has been read into the current buffer, it's offset by the previous 'folder-size' too much. The header can thus not be correctly parsed and the code crashes.