[COMPRESS-718] Adjust size validation for OLD_ASCII format#759
Merged
garydgregory merged 2 commits intoapache:masterfrom Jan 20, 2026
Merged
[COMPRESS-718] Adjust size validation for OLD_ASCII format#759garydgregory merged 2 commits intoapache:masterfrom
garydgregory merged 2 commits intoapache:masterfrom
Conversation
Member
garydgregory
left a comment
There was a problem hiding this comment.
Hello @anayw2001
Thank you for your PR. Do you have a canonical reference for 0x200000000L, like a URL to source? The Wikepedio entry for cpio seems to think the max is 8,589,934,591, and not 8,589,934,592.
Contributor
Author
|
I don't actually! Wasn't sure if it was |
Contributor
Author
|
Updated with the style fix and size fix. |
Member
src/test/java/org/apache/commons/compress/archivers/cpio/CpioArchiveEntryTest.java
Outdated
Show resolved
Hide resolved
Support files up to 8GiB in size for a single entry when using the OLD_ASCII format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support files up to 8GiB in size for a single entry when using the OLD_ASCII format.
Thanks for your contribution to Apache Commons! Your help is appreciated!
Before you push a pull request, review this list:
mvn; that'smvnon the command line by itself.