IMAGING-306: Constants in ColorHsv are not in tune with ColorConversions algorithms #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 100. Also made the calculations simpler.
feat IMAGING-306, fixed RGBtoHSV and HSVtoRGB to have S and V be 0 to…
feat IMAGING-306-NEWTESTS: New tests for ColorConversions added
Added tests for these color classes, currently they seems to pass within an acceptable margin. The margins are 0.01 and 0.001.
…DIN99 feat IMAGING-306-TESTS-HUNTER-DIN99: Add tests for HunterLab, DINo99 & DINb99
…s well as their outputs are now 0-100 for CMY and CMYK.
…n ranges 0-100 instead of 0-1
…KtoCMYand convertCMYtoCMYK calculations have been simplified with division of K inside of ()
…orConversions.convertCMYKtoRGB()
…thod ColorConversions.convertCMYKtoRGB()
…olorConversions.convertCMYKtoRGB()
Imaging 306 CMY CMYK, ColorConversion now expects and outputs doubles 0-100 for CMY,CMYK
Imaging 306 hsl
Member
|
Hi @oskaredv |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have worked on IMAGING-306 as part of a school assignment