Avoid jpeg parse fail due to jfxx and exif #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyunuck
commented
Mar 28, 2018
hyunuck
commented
- add jfxx signature when parsing jpeg
- Avoid jpeg parse fail due to exif
avrilfanomar
approved these changes
Mar 28, 2018
kinow
requested changes
Jul 22, 2018
| exif = getExifMetadata(byteSource, params); | ||
| } catch (Exception e) { | ||
| // exif parse failed. | ||
| } |
Member
There was a problem hiding this comment.
I think we should still fail here. Other parsers such as the TiffImageParser fail, so JpegImageParser not throwing an exception would be wrong.
Also, not even logging the exception can cause problems to users of the API that would have to debug the code to understand why they were not seeing the EXIF metadata, just to find an exception that was not propagated.
The rest of the code looks good. Would you be able to provide at least one unit tests for your code @hyunuck, please?
Thanks
Bruno
Member
There was a problem hiding this comment.
Ping AND there are no tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.