-
Notifications
You must be signed in to change notification settings - Fork 264
perf: Improve performance of normalize_nan #2999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2999 +/- ##
============================================
+ Coverage 56.12% 59.58% +3.46%
- Complexity 976 1377 +401
============================================
Files 119 167 +48
Lines 11743 15493 +3750
Branches 2251 2569 +318
============================================
+ Hits 6591 9232 +2641
- Misses 4012 4962 +950
- Partials 1140 1299 +159 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Comet TPC-H Benchmark ResultsCommit: Query Times
Total Time: 305.71 seconds Automated benchmark run by dfbench |
| Ok(ColumnarValue::Array(Arc::new(new_array))) | ||
| let input = as_primitive_array::<Float32Type>(&array); | ||
| // Use unary which operates directly on values buffer without intermediate allocation | ||
| let result: Float32Array = unary(input, normalize_float); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 unary is fast but it requires the operation to be infallible and this is the case here.
comphead
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @andygrove
|
Thanks for the review @comphead |
Which issue does this PR close?
N/A
Rationale for this change
Avoid some allocations.
What changes are included in this PR?
How are these changes tested?