fix: use coalesce instead of drop_duplicate_keys for join #1318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mesejo
force-pushed
the
fix/coalesce_mutual_keys
branch
from
7f9369d to
d0ecc60
Compare
mesejo
force-pushed
the
fix/coalesce_mutual_keys
branch
from
d0ecc60 to
9f5fa20
Compare
Member
|
I updated the description because I don't think this is a breaking change since the |
timsaucer
approved these changes
Jan 5, 2026
Member
timsaucer
left a comment
timsaucer
left a comment
There was a problem hiding this comment.
Excellent addition. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1305.
What changes are included in this PR?
Use of coalesce to get the non-null key values in the keys in the join, similar to what is done in pyarrow.
Are there any user-facing changes?
The parameter name has changed from
drop_duplicate_keystocoalesce_duplicate_keysbutdrop_duplicate_keysis not an a released version, so this is a new addition.