feat: suport spark compatible floor function#20860
Open
coderfender wants to merge 1 commit intoapache:mainfrom
Open
feat: suport spark compatible floor function#20860coderfender wants to merge 1 commit intoapache:mainfrom
coderfender wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
|
Is this a duplicate of #20594? Test suite here looks more comprehensive, maybe @shivbhatia10 might like to take a look? |
Contributor
Author
|
@xanderbailey Yeah , I initially though since @shivbhatia10 implemented ceil function , I would go for other math function but turns out we have 4 pending PRs from his side and I started reviewing his implementations to help the effort and take one for the team :) |
Contributor
Author
|
@xanderbailey left review as well #20593 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #15914
Rationale for this change
Spark compatible semantics for
floorfunctionWhat changes are included in this PR?
Implements SparkFloor UDF with Spark-compatible return types:
Are these changes tested?
Yes . Added unit tests and SLT tests
Are there any user-facing changes?