[branch-53] fix: move overflow guard before dense ratio in hash join to prevent overflows (#20998)#21008
Merged
comphead merged 1 commit intoapache:branch-53from Mar 17, 2026
Merged
Conversation
…verflows (apache#20998) ## Which issue does this PR close? - Closes apache#20995. ## Rationale for this change apache#20995 has details but it is very straightforward. `dense_ratio` calculation overflows since overflow guard is after not before ## What changes are included in this PR? Prevent hash join overflow and unit test for it ## Are these changes tested? Added a test case for both min and max scenario Co-authored-by: Matt Butrovich <mbutrovich@users.noreply.github.com> (cherry picked from commit e74e58f)
26 tasks
Contributor
|
Looks like runners are struggling to pick up some tasks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit e74e58f)
I confirmed that this fixed CometFuzzTestSuite "join" which found the original issue while testing
branch-53.Which issue does this PR close?
Rationale for this change
#20995 has details but it is very straightforward.
dense_ratiocalculation overflows since overflow guard is after not beforeWhat changes are included in this PR?
Prevent hash join overflow and unit test for it
Are these changes tested?
Added a test case for both min and max scenario