-
Notifications
You must be signed in to change notification settings - Fork 75
feat: AoS tuple sketch #476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 21757025873Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
This reverts commit 4894e5e.
|
@tisonkun |
|
@proost, I would like to discourage adding third-party dependencies in our code base (especially non-standard ones) as it complicates code integration, debugging, and maintenance. In C++, we use the C++ Standard Library, Boost, XxHash64, and public domain MurmurHash3, all of which are extremely well known and tested. I'm not so sure about this code from Nemanja Trifunovic. Is it versioned? Does it follow a rigorous release process? Is it maintained? Do we absolutely have to have it? His License header is non-standard, we may need to have it approved. |
|
@leerho I agree that bringing in a third-party UTF-8 library (and its non-standard license header) is a significant cost: integration, maintenance, debugging, and licensing updates. I see three possible approaches:
Based on your feedback, I propose we go with option (1). If you prefer a different direction, I can adjust. |
issue: #475
I change original design. I will follow same design with array of doubles sketch, that allow allocator for container not the element of container. I think using standard allocator for string is fine, for consistency of code following same design is good And even if we use custom allocator, we can't use completely for string allocation because of serialization and deserialization.
even though above reasons, if want to change to orignal design, it is acceptable.