Skip to content

Conversation

@Yukang-Lian
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Sep 24, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

w41ter
w41ter previously approved these changes Sep 24, 2025
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 24, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@Yukang-Lian Yukang-Lian force-pushed the Modify-Snapshot-Http-Interface branch from 4826162 to deb44ad Compare September 24, 2025 08:32
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Sep 24, 2025
w41ter
w41ter previously approved these changes Sep 24, 2025
dataroaring
dataroaring previously approved these changes Sep 24, 2025
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yukang-Lian Yukang-Lian dismissed stale reviews from dataroaring and w41ter via 34780c6 September 24, 2025 08:43
@Yukang-Lian
Copy link
Collaborator Author

run buildall

@doris-robot
Copy link

Cloud UT Coverage Report

Increment line coverage 55.17% (32/58) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.75% (1567/1871)
Line Coverage 67.96% (27943/41115)
Region Coverage 68.33% (13754/20128)
Branch Coverage 58.65% (7343/12520)

@w41ter
Copy link
Contributor

w41ter commented Sep 24, 2025

run buildall

@doris-robot
Copy link

Cloud UT Coverage Report

Increment line coverage 55.17% (32/58) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.75% (1567/1871)
Line Coverage 67.92% (27924/41115)
Region Coverage 68.27% (13741/20128)
Branch Coverage 58.51% (7326/12520)

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage `` 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.40% (17609/33604)
Line Coverage 37.62% (159969/425241)
Region Coverage 32.15% (121967/379324)
Branch Coverage 33.51% (53496/159654)

@doris-robot
Copy link

ClickBench: Total hot run time: 0.04 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 34780c63baea042f074604a1f99cb95c3b0bfb73, data reload: false

query1	0.05	0.02	0.00
query2	0.12	0.01	0.01
query3	0.31	0.00	0.01
query4	1.71	0.01	0.01
query5	0.27	0.00	0.00
query6	1.69	0.02	0.02
query7	0.04	0.00	0.00
query8	0.08	0.00	0.00
query9	0.66	0.00	0.00
query10	0.60	0.00	0.00
query11	0.27	0.00	0.01
query12	0.26	0.00	0.00
query13	0.66	0.00	0.00
query14	1.06	0.00	0.00
query15	0.98	0.00	0.01
query16	0.41	0.00	0.00
query17	1.06	0.00	0.00
query18	0.25	0.00	0.00
query19	2.03	0.00	0.00
query20	0.03	0.00	0.00
query21	15.37	0.00	0.00
query22	5.71	0.01	0.00
query23	15.58	0.00	0.00
query24	1.80	0.00	0.00
query25	0.17	0.00	0.00
query26	0.20	0.00	0.00
query27	0.11	0.00	0.01
query28	1.78	0.00	0.00
query29	12.74	0.00	0.00
query30	0.34	0.00	0.00
query31	2.66	0.00	0.00
query32	6.28	0.00	0.00
query33	4.30	0.01	0.00
query34	8.67	0.00	0.01
query35	7.63	0.01	0.00
query36	0.65	0.00	0.00
query37	0.24	0.00	0.00
query38	0.20	0.00	0.00
query39	0.06	0.00	0.01
query40	0.22	0.00	0.00
query41	0.13	0.00	0.00
query42	0.09	0.00	0.00
query43	0.07	0.00	0.01
Total cold run time: 97.54 s
Total hot run time: 0.04 s

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 25, 2025
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@w41ter
Copy link
Contributor

w41ter commented Sep 25, 2025

run check_coverage

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.19% (23356/32807)
Line Coverage 57.58% (244193/424085)
Region Coverage 53.02% (203797/384354)
Branch Coverage 54.60% (87528/160303)

@w41ter w41ter merged commit 92651f7 into apache:master Sep 25, 2025
27 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. cloud reviewed snapshot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants