Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #56382

This commit modified the caching logic for the Segment footer.

Previously, the Segment footer was cached in the `DATA_PAGE` cache. This
was incorrect as the footer is metadata, not data. This commit changes
it to use the more appropriate `INDEX_PAGE` cache.

Additionally, the calculation for `_meta_mem_usage` has been adjusted
for better accuracy. The footer size is no longer included in the
calculation since it's now managed by the `StoragePageCache`. The memory
estimation for column readers is also updated to use
`config::max_segment_partial_column_cache_size` for a more realistic
value.
@Thearas
Copy link
Contributor

Thearas commented Sep 25, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Sep 25, 2025
@Thearas
Copy link
Contributor

Thearas commented Sep 25, 2025

run buildall

@doris-robot
Copy link

ClickBench: Total hot run time: 30.56 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5e0d066511470f0f2e74d42537b2f78cfc817528, data reload: true

query1	0.03	0.03	0.03
query2	0.11	0.04	0.04
query3	0.28	0.06	0.07
query4	1.75	0.12	0.11
query5	0.26	0.24	0.25
query6	1.23	0.65	0.66
query7	0.03	0.02	0.02
query8	0.06	0.03	0.03
query9	0.60	0.54	0.55
query10	0.58	0.58	0.60
query11	0.18	0.11	0.11
query12	0.16	0.12	0.12
query13	0.63	0.62	0.61
query14	0.81	0.81	0.81
query15	0.88	0.86	0.86
query16	0.38	0.40	0.39
query17	1.06	1.03	1.06
query18	0.20	0.19	0.20
query19	1.93	1.84	1.79
query20	0.02	0.01	0.02
query21	15.44	0.90	0.57
query22	0.81	1.00	0.81
query23	15.07	1.40	0.64
query24	16.29	1.50	0.60
query25	2.25	0.41	0.22
query26	0.19	0.18	0.18
query27	0.20	0.22	0.20
query28	1.80	1.03	0.95
query29	12.74	3.90	3.23
query30	0.30	0.13	0.11
query31	2.99	0.60	0.39
query32	3.32	0.57	0.47
query33	3.05	3.11	3.04
query34	16.87	5.38	4.93
query35	5.06	5.08	5.22
query36	0.74	0.55	0.55
query37	0.11	0.07	0.07
query38	0.06	0.05	0.04
query39	0.04	0.03	0.03
query40	0.18	0.15	0.15
query41	0.08	0.03	0.02
query42	0.04	0.03	0.02
query43	0.05	0.04	0.04
Total cold run time: 108.86 s
Total hot run time: 30.56 s

@yiguolei yiguolei merged commit 19f4e25 into branch-4.0 Sep 27, 2025
21 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants