Skip to content

Conversation

RainYuY
Copy link
Contributor

@RainYuY RainYuY commented Aug 22, 2025

What is the purpose of the change?

This PR will do three things:

  • Move the IntegrationTest to the dubbo-integration repository.

  • Clean up the UT files that are not run during mvn test.

  • Remove the module’s dependency on the real Zookeeper.

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.01%. Comparing base (c831fef) to head (ea365b8).
⚠️ Report is 1 commits behind head on 3.3.

Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #15654      +/-   ##
============================================
- Coverage     61.01%   61.01%   -0.01%     
+ Complexity    11704    11690      -14     
============================================
  Files          1910     1910              
  Lines         86806    86806              
  Branches      13100    13100              
============================================
- Hits          52968    52965       -3     
+ Misses        28419    28417       -2     
- Partials       5419     5424       +5     
Flag Coverage Δ
integration-tests-java21 33.00% <ø> (-0.01%) ⬇️
integration-tests-java8 33.10% <ø> (-0.02%) ⬇️
samples-tests-java21 32.73% <ø> (+0.03%) ⬆️
samples-tests-java8 30.43% <ø> (+0.01%) ⬆️
unit-tests-java11 59.03% <ø> (+0.02%) ⬆️
unit-tests-java17 58.72% <ø> (-0.01%) ⬇️
unit-tests-java21 58.71% <ø> (-0.01%) ⬇️
unit-tests-java8 59.03% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zrlw zrlw self-requested a review August 22, 2025 09:10
@zrlw
Copy link
Contributor

zrlw commented Aug 22, 2025

LGTM

@zrlw zrlw requested a review from FoghostCn August 22, 2025 09:11
@zrlw zrlw added the type/proposal Everything you want Dubbo have label Aug 30, 2025
@RainYuY RainYuY marked this pull request as ready for review September 23, 2025 14:23
@RainYuY RainYuY merged commit f6b78d2 into apache:3.3 Sep 23, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/proposal Everything you want Dubbo have
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants