[FLUSS-2526][server] Fix accidental remote KV snapshot deletion during rebalance #2556
+205
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #2526
This PR addresses the issue where rebalancing a primary key table leads to a
KvSnapshotNotExistException. The problem was that when a bucket replica was moved during rebalancing, the tablet server being stopped was incorrectly deleting shared remote snapshots from the filesystem, which the new leader still needed to function.Brief change log
ReplicaManager#stopReplicaby removing the logic that triggeredkvManager.deleteRemoteKvSnapshot.deleteflag was set.Tests
KvSnapshotDeletionBugReplicationTesttofluss-server.KvSnapshotNotExistExceptionpreviously seen by leaders after a rebalance.API and Format
no
Documentation
no