Skip to content

Fixing bug with geode home determination #7550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Fixing bug with geode home determination #7550

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a0cb96
Fixing bug with geode home determination
Apr 4, 2022
1804834
Update gfsh.bat
Apr 6, 2022
28920ca
Update gfsh.bat
onichols-pivotal May 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion geode-assembly/src/main/dist/bin/gfsh.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ REM

setlocal enableextensions
set scriptdir=%~dp0
set gf=%scriptdir:\bin\=%
set gf=%scriptdir:~0,-4%
Copy link
Contributor

@jdeppe-pivotal jdeppe-pivotal Apr 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you just add a short comment so anyone else, looking at this in the future, knows why 4 in particular. Maybe:

REM Remove last 4 chars corresponding to bin\

Copy link
Author

@thesteve0 thesteve0 Apr 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do

REM echo %gf%
REM echo %scriptdir%
if exist "%gf%\lib\geode-dependencies.jar" goto gfok
Expand Down