GUACAMOLE-2199: Adds support dynamic Base URL injection via configured header. Includes unit tests for API compatibility.#1146
Open
rogerberaldi wants to merge 1 commit intoapache:mainfrom
Conversation
…d header. Includes unit tests for API compatibility.
292b2e3 to
db3342a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Issue: https://issues.apache.org/jira/browse/GUACAMOLE-2199
Overview:
This PR enables support for stateless load balancing architectures (e.g., Kubernetes Ingress, Zero-Trust Gateways) where sticky sessions are unavailable or unreliable. It introduces a configurable property that allows an upstream proxy to explicitly dictate the client's Base URL via an HTTP header.
Changes:
auth-base-url-headeringuacamole.properties.APIAuthenticationResultto include abaseUrlfield.APIAuthenticationResultto ensure binary compatibility with existing extensions.TokenRESTServiceto inspect the configured header and inject the URL (replacing{TOKEN}placeholder) into the auth response.Verification:
APIAuthenticationResultTestto verify backward compatibility of constructors and correct injection of thebaseUrlfield.mvn testpassed.