Skip to content

907: Improve META-INF/MANIFEST.MF #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

907: Improve META-INF/MANIFEST.MF #916

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b712fb1
Improved META-INF/MANIFEST.MF content
rohitYaduvanshi Jan 13, 2025
8ae6c48
Fix formatting issues
rohitYaduvanshi Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -719,8 +719,11 @@ limitations under the License.
<archive>
<manifestEntries>
<Build-Date>${project.build.outputTimestamp}</Build-Date>
<Build-Version>${project.version}</Build-Version>
<Build-Jdk>${java.version}</Build-Jdk>
<Build-Version>${project.version}</Build-Version>
<Build-Jdk>${java.version}</Build-Jdk>
<Specification-Title>Apache Baremaps CSV (incubating)</Specification-Title>
Copy link
Member

@bchapuis bchapuis Jan 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rohitYaduvanshi Thanks for this PR. I guess we should probably add a <name> tag in all sub modules (e.g baremaps-csv/pom.xml) and use it to generate the Specification-Title dynamically. From what I understand, with the current solution, all the generated jars will have the same specification title.

<name>baremaps-csv</name>

...

<Specification-Title>${project.name}</Specification-Title>

<Specification-Vendor>Apache Software Foundation</Specification-Vendor>
<Implementation-Vendor>Apache Software Foundation</Implementation-Vendor>
</manifestEntries>
</archive>
</configuration>
Expand Down
Loading