Move the Auth module from server to common for reuse#7280
Move the Auth module from server to common for reuse#7280Yao-MR wants to merge 1 commit intoapache:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7280 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 697 698 +1
Lines 43587 43627 +40
Branches 5893 5893
======================================
- Misses 43587 43627 +40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
It looks like a break change. I saw you want to enable the authentication for metrics port. How about using the reflection to inject the AuthenticationFilter in kyuubi-metrics module? Please add an config item for the new feature and disable it by defaults. |
@turboFei yes, it is a break change , and also we can use reflection to reslove this for reuse, but there is a problem that all the class releated with authoration is in the server module, what is your idea? |
|
@pan3793 either keeping the package name same or using reflection. |
Why are the changes needed?
Move the most module related with auth to common for further reuse
How was this patch tested?
Test with all the UT
Was this patch authored or co-authored using generative AI tooling?
NO