Fix marshalling for OutputDebugString parameter, add unit test#271
Merged
FreeAndNil merged 4 commits intoapache:masterfrom Sep 12, 2025
Merged
Conversation
FreeAndNil
reviewed
Sep 12, 2025
Contributor
FreeAndNil
left a comment
FreeAndNil
left a comment
There was a problem hiding this comment.
@ban-dana an adjustment for the test is needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that the default charset for the DllImport is Ansi which screws unicode strings on their way to the win32 OutputDebugString.
Set the CharSet explictly, also added a unit test (though, there seems to be no way of easily verifying that the actual api was indeed called and the data marshalled properly).
I can think of something Detours-based, but maybe that's an overkill for such a simple thing.