Use JSoup to convert HTML to XHTML after parsing with Flexmark

[kwin]

That way valid XHTML is passed to the XHTML parser. This is crucial as markdown may contain elements which are no properly closed (for example inline html5 with unclosed

tags)

This closes #999

Following this checklist to help us incorporate your
contribution quickly and easily:

• Your pull request should address just one issue, without pulling in other changes.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Each commit in the pull request should have a meaningful subject line and body.
  Note that commits might be squashed by a maintainer on merge.
• Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
  This may not always be possible but is a best-practice.
• Run mvn verify to make sure basic checks pass.
  A more thorough check will be performed on your pull request automatically.
• You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

• I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
• In any other case, please file an Apache Individual Contributor License Agreement.

[michael-o]

There is no way to configure flexmark?

The is yet another problem with JSoup. The the library is great, the license conditions are problematic to distribute. There was a report about this in Wagon and at the end I have removed JSoup because of this. Please look up the issue in JIRA.

[kwin]

JSoup is MIT which is according to https://www.apache.org/legal/resolved.html#category-a Category A and fully fine with ASF policies.

[michael-o]

JSoup is MIT which is according to https://www.apache.org/legal/resolved.html#category-a Category A and fully fine with ASF policies.

No: https://issues.apache.org/jira/browse/WAGON-619

[cstamas]

But are we shading it in this case? I don't get what the problem is?

[michael-o]

But are we shading it in this case? I don't get what the problem is?

I don't that shading is the problem, but using the binary library.

[cstamas]

Again, why? Can you explain in one sentence?

So you say depending on MIT licensed JAR is to be avoided?

[cstamas]

As I see on ML the sentence that causes the problem when jsoup is included in build result is "The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.", but here, a plain maven dependency is declared, and is nothing like that (shading/copying). JSoup will not be present in the artifacts (source or binaries) we will once vote upon either.

Again, no idea what are you implying.

[michael-o]

As I see on ML the sentence that causes the problem when jsoup is included in build result is "The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.", but here, a plain maven dependency is declared, and is nothing like that (shading/copying). JSoup will not be present in the artifacts (source or binaries) we will once vote upon either.

Again, no idea what are you implying.

IANAL. Just wanted to make you guys aware of previous discussion.

[cstamas]

IANAL either, but there (in "wagon case") it was shading the obvious problem: you "included" (copied) JSoup software into your software and you put it on ASF vote. Basically JSoup became part of the vote.